Last modified: 2013-02-12 15:32:19 UTC
Gerrit drafts aren't currently testable:
- there is a undocumented recheck feature to run basic Jenkins tests, but no documented testing command
- it's not possible anymore to manually trigger a build from Jenkins through Query and Trigger Gerrit Patches ("No jobs triggered for this event")
This is at least a major priority, perhaps a critical one as any serious work on core is currently impeded by the following double constraint:
(1) any change has to be tested (and by the way I'm not writing tests not to run it)
(2) any change on Gerrit changes should be drafts, to avoid flood (per TimStarling request)
Run tests locally can't seriously considered as a viable solution, per the RAM/CPU required for these tests compared to the Jenkins servers power and the fact Jenkins tasks are comprehensive and up to date.
I can't think of an easy way to do this, other than adding Jenkins as a reviewer on a change (so it'll be able to see it). I don't think there's much else we can do on the Gerrit side--it should probably be more Zuul tweaks.
More interestingly, a "View drafts" permission would be cool for people who should be able to see all Draft changes, but I haven't looked at how easy this would be (just filed upstream: https://code.google.com/p/gerrit/issues/detail?id=1754)
(In reply to comment #1)
> More interestingly, a "View drafts" permission would be cool for people who
> should be able to see all Draft changes, but I haven't looked at how easy
> would be (just filed upstream:
Actually, just found out this was already done in master and will be a grantable permission upon upgrading.
Marking the dependency, because this will be *trivial* once we upgrade.
This is now done on the Gerrit side, JenkinsBot should be able to view all drafts.
This should *just work* now. If it doesn't please let me know and we can reopen.