Last modified: 2013-08-15 19:12:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45689, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43689 - Implement "Templates used on this page" collapsing below edit window and the rest of Vector's footercleanup module in core
Implement "Templates used on this page" collapsing below edit window and the ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.21.x
All All
: Low enhancement (vote)
: 1.22.0 release
Assigned To: Bartosz Dziewoński
:
Depends on: 45977
Blocks: 45051
  Show dependency treegraph
 
Reported: 2013-01-07 00:54 UTC by MZMcBride
Modified: 2013-08-15 19:12 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-01-07 00:54:11 UTC
Currently on the English Wikipedia using the Vector skin, the list of templates used on a page that's available below the edit window is collapsed using JavaScript (e.g., <https://en.wikipedia.org/w/index.php?title=Main_Page&action=edit>). This enhancement should be available on other Wikimedia wikis.
Comment 1 Andre Klapper 2013-02-26 20:17:23 UTC
<div class="templatesUsed"><div class="mw-templatesUsedExplanation"><p><span id="templatesused">Pages <a href="/wiki/Wikipedia:Transclusion" title="Wikipedia:Transclusion">transcluded</a> onto the current version of this page:</span>
</p></div>
Comment 2 Bartosz Dziewoński 2013-03-09 23:32:37 UTC
Reappropriating this bug slightly – let's just implement it on core.

Also taking this bug. I'll try to do this soon-ish, shouldn't be too much work.
Comment 3 Bartosz Dziewoński 2013-03-10 20:27:56 UTC
So I discovered that doing this properly will require some more work.

Mostly, I'd like to avoid copying over the $.footerCollapsibleList module and use $.makeCollapsible from core.

This will require adding some hooks to it in order to provide the cookie persistence support $.footerCollapsibleList provides in the footer cleanup implementation itself.

When trying to do this, and discovered that $.makeCollapsible sucks more than I anticipated. I started submitting related patches to gerrit under the 'footer-cleanup-bug-43689' topic branch in mediawiki/master: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+topic:footer-cleanup-bug-43689,n,z
Comment 4 Krinkle 2013-03-10 23:42:05 UTC
This is currently part of the Vector extension. The Vector extension, like the WikiEditor extension, has lots of standlone experimental features that are mostly disabled by default.

It is only visible on English Wikipedia because it was decided to enable this particular one (ext.vector.footerCleanup) there.

Other wikis can do the same, there is no software change required for that. So unless there are local hacks I don't know about this is a duplicate of bug 45051.

If we want it on other wikis sooner (since bug 45051 will likely make it the default in core) a request on Meta could be made to make it the default on Wikipedia or all WMF projects, or request on local village pumps and put it on Wikimedia > Site requests.

Marking this bug duplicate of bug 45051 and assuming that it was incorrectly mistaken for an en.wikipedia hack.

The software changes Bartosz look interesting but are otherwise unrelated to this bug, Vector isn't even using that module.

*** This bug has been marked as a duplicate of bug 45051 ***
Comment 5 Krinkle 2013-03-10 23:43:20 UTC
See bug 45946, for example, which requests it for commonswiki.
Comment 6 Matthew Flaschen 2013-03-11 02:27:11 UTC
This blocks 45051.  It's not a duplicate.
Comment 7 Helder 2013-03-11 16:29:27 UTC
(In reply to comment #3)
> Mostly, I'd like to avoid copying over the $.footerCollapsibleList module and
> use $.makeCollapsible from core.

Yes, please! That is what I suggested when this first arrived on English Wikipedia.[1]

[1] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_104#Upcoming_changes_to_the_edit_window_.28please_read.29
Comment 8 Bartosz Dziewoński 2013-03-15 22:03:25 UTC
I submitted a lot of commits to make $.makeCollapsible itself more bearable, then a few more to make it more useful, then a partial draft of this reimplementation: 72e8ae60dbc. This particular change will include only the collapsible lists; I'll implement the general restyling separately (as it'll be much more straightforward, mostly just copying over the CSS).
Comment 9 Bartosz Dziewoński 2013-03-15 22:04:36 UTC
I91a3704c, that is, I copied the wrong hash.
Comment 10 Gerrit Notification Bot 2013-05-29 14:22:01 UTC
Related URL: https://gerrit.wikimedia.org/r/65987 (Gerrit Change I756927b3f25f8fe701b74cb664653d3930cf7660)
Comment 11 Gerrit Notification Bot 2013-07-26 05:25:03 UTC
Change 54089 merged by jenkins-bot:
Make the templates/category lists on edit page collapsible

https://gerrit.wikimedia.org/r/54089
Comment 12 Gerrit Notification Bot 2013-07-26 05:31:14 UTC
Change 65987 merged by jenkins-bot:
Move jquery.footerCollapsibleList to core

https://gerrit.wikimedia.org/r/65987
Comment 13 Bartosz Dziewoński 2013-07-26 09:56:35 UTC
Hooray, the largest and hairiest part is now done. Now let's move the styles for the edit form's footer – I'll submit a few patches to do that in a while.
Comment 14 Gerrit Notification Bot 2013-07-26 10:26:42 UTC
Change 76067 had a related patch set uploaded by Matmarex:
mediawiki.action.edit: Add styles for edit form's footer

https://gerrit.wikimedia.org/r/76067
Comment 15 Gerrit Notification Bot 2013-07-26 10:26:47 UTC
Change 76068 had a related patch set uploaded by Matmarex:
EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a <span>

https://gerrit.wikimedia.org/r/76068
Comment 16 Gerrit Notification Bot 2013-07-26 10:27:07 UTC
Change 76069 had a related patch set uploaded by Matmarex:
Hide MediaWiki's "Editing help" link, as we provide it in the toolbar

https://gerrit.wikimedia.org/r/76069
Comment 17 Gerrit Notification Bot 2013-07-26 10:27:25 UTC
Change 76070 had a related patch set uploaded by Matmarex:
Delete the ext.vector.footerCleanup module

https://gerrit.wikimedia.org/r/76070
Comment 18 Bartosz Dziewoński 2013-07-26 10:28:37 UTC
These four changes complete the migration.
Comment 19 Gerrit Notification Bot 2013-08-15 18:31:28 UTC
Change 76067 merged by TheDJ:
mediawiki.action.edit: Add styles for edit form's footer

https://gerrit.wikimedia.org/r/76067
Comment 20 Gerrit Notification Bot 2013-08-15 18:31:46 UTC
Change 76068 merged by TheDJ:
EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a <span>

https://gerrit.wikimedia.org/r/76068
Comment 21 Gerrit Notification Bot 2013-08-15 18:38:12 UTC
Change 76069 merged by jenkins-bot:
Hide MediaWiki's "Editing help" link, as we provide it in the toolbar

https://gerrit.wikimedia.org/r/76069
Comment 22 Gerrit Notification Bot 2013-08-15 19:11:27 UTC
Change 76070 merged by jenkins-bot:
Delete the ext.vector.footerCleanup module

https://gerrit.wikimedia.org/r/76070
Comment 23 Bartosz Dziewoński 2013-08-15 19:12:49 UTC
This is done now! Hooray!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links