Last modified: 2007-08-31 08:48:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6358, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 4358 - Special:Review - bug fixing and enhancement concerning page_id (& title)
Special:Review - bug fixing and enhancement concerning page_id (& title)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.magnusmanske.de/wikipeerdi...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2005-12-22 16:06 UTC by Henning Heitkötter
Modified: 2007-08-31 08:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
See above (1.67 KB, patch)
2005-12-22 16:07 UTC, Henning Heitkötter 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Henning Heitkötter 2005-12-22 16:06:33 UTC 
Invoking Special:Review without a page_id supplied (but a mode) triggers an
fatal error (see URL), as the existence of the $title-object isn't checked
before invoking view_version_statistics (resp. view_version_statistics).

The following patch fixes this bug, additionally, it allows to provide the page
to be reviewed as a title-String (e.g. Special:Review/Main_Page) by evaluating
the $par-argument of SpecialPage::execute (if the page_id-param isn't set).
Furthermore  view_page_statistics is set as the default mode.
Comment 1 Henning Heitkötter 2005-12-22 16:07:15 UTC 
Created attachment 1228 [details]
See above
Comment 2 Aaron Schulz 2007-08-31 08:48:32 UTC 
Done in r25340.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links