Last modified: 2014-04-15 06:22:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45164, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43164 - Remove square brackets in patrol link after click
Remove square brackets in patrol link after click
Status: NEW
Product: MediaWiki
Classification: Unclassified
Patrolling (Other open bugs)
1.21.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31270
  Show dependency treegraph
 
Reported: 2012-12-15 23:35 UTC by Nemo
Modified: 2014-04-15 06:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2012-12-15 23:35:42 UTC
With the new AJAX patrol, after clicking the patrol button the text is replaced with the loading icon, but the brackets around it are kept until the action is completed, which is a bit ugly.
Low priority because it's usually so quick as to go unnoticed.
Comment 1 Krinkle 2012-12-16 16:53:11 UTC
It was actually implemented that way on purpose (changing to 'enhancement').

But I can see how they look out of place. We do need to keep them though, for the case where the action fails (need to restore them, without hardcoding them in the client side error handler).

I'd say instead of removing the label, inserting the loader, and re-inserting the message on error. Let's hide the entire thing (display none), add the loader, and then either remove both or remove loader and show original.
Comment 2 Nemo 2012-12-16 17:46:01 UTC
(Moving the dependency to its "parent" bug because Krinkle complained about the dependency relation to the tracking bug being unclear.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links