Last modified: 2014-10-01 12:50:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44924, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42924 - Wrong sorting in tables with {{formatnum}} in Spanish Wikipedia (es.wp) due to spaces to separate thousands
Wrong sorting in tables with {{formatnum}} in Spanish Wikipedia (es.wp) due t...
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.21.x
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 56952 (view as bug list)
Depends on:
Blocks: 31601
  Show dependency tree / graph
 
Reported: 2012-12-10 21:28 UTC by David Abián
Modified: 2014-10-01 12:50 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Abián 2012-12-10 21:28:18 UTC 
After the implementation of the spaces to separate thousands with {{formatnum:}}, sortable tables do not work well with them.

You can test an example in http://es.wikipedia.org/wiki/Usuario:Invadinado/testing-tables

Thanks in advance.
Comment 1 Bartosz Dziewoński 2012-12-10 22:37:47 UTC 
$.tablesorter doesn't consider space a valid number separator, and it's not included in the regex for detecting numbers that's built on line 391 of resources/jquery/jquery.tablesorter.

I'm not sure if we can just include it there, or if it's going to cause some breakage.
Comment 2 Bartosz Dziewoński 2012-12-10 22:42:38 UTC 
Actually, it seems like it is, coming from wgSeparatorTransformTable. I'd have to look into it more to figure out what's happening.
Comment 3 db [inactive,noenotif] 2013-03-10 17:17:56 UTC 
The vars are correct:
"wgSeparatorTransformTable":[",	."," 	,"]
"wgDigitTransformTable":["",""]
And tablesort splits by the \t

Looks like the regex get confused by the space and only getting the first block as number.
Comment 4 Bartosz Dziewoński 2013-11-12 19:40:58 UTC 
*** Bug 56952 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links