Last modified: 2014-01-08 16:47:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44642, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42642 - Redirect category (Rcat) templates on redirect pages no longer render text on Diff pages of redirect
Redirect category (Rcat) templates on redirect pages no longer render text on...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.21.x
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-03 05:36 UTC by Paine Ellsworth
Modified: 2014-01-08 16:47 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Paine Ellsworth 2012-12-03 05:36:37 UTC
When redirect category (Rcat) templates are placed on redirect pages, they no longer render text on the Diff pages of the redirect.  It is hoped that this is to resolve bug 14323, which asks for text to be rendered directly on redirects.  In a recent discussion on that bug page, it came out that the Rcat text was removed from Diff pages "to standardize with the article display".  Is that the case?  If so, how does removing Rcat text from Diff pages standardize those pages with article Diff pages that show the complete article below the Diff panels?  The Rcat text needs to be displayed, either directly on redirects (the preferred way), or the text should be displayed as it was before:  on Diff pages.  Thank you very much!
Comment 1 Andre Klapper 2012-12-03 11:27:16 UTC
Brad: Could you elaborate your comment from bug 14323 comment 21 here, if possible?
Comment 2 Brad Jorsch 2012-12-03 14:37:37 UTC
The change was made in Ic3c2d6cf with the comment "Show redirects correctly on diff pages". Sounds to me like the reasoning was to render the redirect as is done on the standard article view, instead of parsing it as an odd ordered list at the beginning of the article.

What really needs to be done is to just fix bug 14323 already, which should encompass article views, edit previews, and diff views as well as any extensions (FlaggedRevs and TemplateSandbox are two I know of).
Comment 3 Chris McKenna 2012-12-09 13:41:49 UTC
Previews of redirects are also not showing any categories that the redirect is in via a template, either already or that it will be in if the edit is saved. 

These categories used to be shown, the change that broke this presumably occurring at the same time as the above.
Comment 4 Paine Ellsworth 2012-12-13 01:24:53 UTC
(In reply to comment #3)
> Previews of redirects are also not showing any categories that the redirect
> is
> in via a template, either already or that it will be in if the edit is
> saved. 
> 
> These categories used to be shown, the change that broke this presumably
> occurring at the same time as the above.

Yes, that was working on and off for me.  When the cats don't show on Preview, that's a bit agitatin'.  I always figured that background changes were being made that sometimes enabled the cat preview and sometimes disabled it.
Comment 5 Chris McKenna 2012-12-21 10:41:01 UTC
Could this bug be behind unprintworthy redirects no longer being excluded from the search suggestions list? Or is that a separate issue?

See http://en.wikipedia.org/wiki/Help_talk:Searching#Unprintworthy_redirects_are_not_being_excluded_from_the_search_dropdown_as_expected for a bit of background on this.
Comment 6 Gerrit Notification Bot 2014-01-06 21:30:28 UTC
Change 105829 had a related patch set uploaded by Anomie:
Move redirect rendering into WikitextContent

https://gerrit.wikimedia.org/r/105829
Comment 7 Gerrit Notification Bot 2014-01-07 22:45:04 UTC
Change 105829 merged by jenkins-bot:
Move redirect rendering into WikitextContent

https://gerrit.wikimedia.org/r/105829
Comment 8 Brad Jorsch 2014-01-08 16:47:23 UTC
Should be deployed to WMF wikis with 1.23wmf10, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links