Last modified: 2014-09-09 18:23:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44554, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42554 - Title Blacklist changes are no longer performed in real-time
Title Blacklist changes are no longer performed in real-time
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nischay Nahata
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-29 19:51 UTC by Erik Moeller
Modified: 2014-09-09 18:23 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Moeller 2012-11-29 19:51:15 UTC
It used to be the case that Upload Wizard checked titles against the title blacklist ( https://commons.wikimedia.org/wiki/MediaWiki:Titleblacklist ) as you updated them in the "Describe" step. This check appears to have been broken somewhere along the way. We still have a catch-all check once the user presses "submit", but that's a slower and uglier way of doing things.

It'd be good to restore the original check.

(Tested in Chrome 22. Steps to reproduce: Upload a batch of files and give them titles like DSC03435 - expected behavior, warnings should appear immediately. Actual behavior, warnings only appear once files are submitted.)
Comment 1 Nischay Nahata 2013-01-24 13:42:03 UTC
Unable to reproduce on master, I get the error message 'Please make this title more meaningful.'
However, able to reproduce on commons.

I suspect the problem is explained by the comment in jquery.validate.wmCommonsBlacklist.js

 * These checks are ignored when the TitleBlacklist API is available
Comment 2 Nischay Nahata 2013-01-24 13:49:22 UTC
confirmed that Title Blacklist is installed on Commons.
Comment 3 Nischay Nahata 2013-02-26 20:26:31 UTC
first attempt to fix this by checking with the Title Blacklist Api
https://gerrit.wikimedia.org/r/#/c/50953/
Comment 4 Nischay Nahata 2013-02-26 20:53:18 UTC
Noting that http://commons.wikimedia.org/w/api.php?action=titleblacklist&format=json&tbaction=create&tbtitle=DSC03435 says ok so it might be an issue with TitleBlacklist
Comment 5 Gerrit Notification Bot 2013-03-20 21:17:26 UTC
https://gerrit.wikimedia.org/r/50953 (Gerrit Change I3cc0f0dd9c6930a98ddfb2657c891150688b05f5) | Patch Set 4:

Would it be terribly difficult to make the checks asynchronous, with a callback chain, and do this properly? I feel like this will block the browser while we check, which seems less than ideal. [by MarkTraceur]
Comment 6 Mark Holmquist 2014-09-09 18:22:11 UTC
I think this got fixed when we fixed the unrelated titleblacklist problems in https://gerrit.wikimedia.org/r/158337 - working in beta anyway.
Comment 7 Gerrit Notification Bot 2014-09-09 18:23:11 UTC
Change 50953 abandoned by MarkTraceur:
Test titles in Details step.

Reason:
No longer necessary, bug fixed because of unrelated issue

https://gerrit.wikimedia.org/r/50953

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links