Last modified: 2012-12-12 16:36:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44547, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42547 - TermSqlCache deadlocks
TermSqlCache deadlocks
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High critical (vote)
: ---
Assigned To: Daniel Kinzler
:
: 42798 (view as bug list)
Depends on: 42685
Blocks: 28599
  Show dependency treegraph
 
Reported: 2012-11-29 18:42 UTC by Aaron Schulz
Modified: 2012-12-12 16:36 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aaron Schulz 2012-11-29 18:42:00 UTC
I'm seeing this kind of error in the logs with modest frequency (some hours there are a lot and others not many):

wikidatawiki    Wikibase\TermSqlCache::saveTermsOfEntity        10.0.6.44       1213    Deadlock found when trying to get lock; try restarting transaction (10.0.6.44)  INSERT  INTO `wb_terms` (term_language,term_type,term_text,term_entity_id,term_entity_type) VALUES ('de','label','Ylläsjoki','202119','item')
Comment 1 Aaron Schulz 2012-12-03 19:20:51 UTC
2012-12-03 10:10:41 mw62 wikidatawiki: #0 /usr/local/apache/common-local/php-1.21wmf5/includes/db/Database.php(962): DatabaseBase->reportQueryError('Deadlock found ...', 1213, 'INSERT  INTO `w...', 'Wikibase\TermSq...', false)
#1 /usr/local/apache/common-local/php-1.21wmf5/includes/db/Database.php(1720): DatabaseBase->query('INSERT  INTO `w...', 'Wikibase\TermSq...')
#2 /usr/local/apache/common-local/php-1.21wmf5/extensions/Wikibase/repo/includes/store/sql/TermSqlCache.php(91): DatabaseBase->insert('wb_terms', Array, 'Wikibase\TermSq...')
#3 /usr/local/apache/common-local/php-1.21wmf5/extensions/Wikibase/repo/includes/updates/EntityModificationUpdate.php(76): Wikibase\TermSqlCache->saveTermsOfEntity(Object(Wikibase\ItemObject))
#4 /usr/local/apache/common-local/php-1.21wmf5/includes/DataUpdate.php(100): Wikibase\EntityModificationUpdate->doUpdate()
#5 /usr/local/apache/common-local/php-1.21wmf5/includes/WikiPage.php(2047): DataUpdate::runUpdates(Array)
#6 /usr/local/apache/common-local/php-1.21wmf5/includes/WikiPage.php(1884): WikiPage->doEditUpdates(Object(Revision), Object(User), Array)
#7 /usr/local/apache/common-local/php-1.21wmf5/extensions/Wikibase/repo/includes/content/EntityContent.php(397): WikiPage->doEditContent(Object(Wikibase\ItemContent), '/* wbsetentity ...', 81, 0, Object(User))
#8 /usr/local/apache/common-local/php-1.21wmf5/extensions/Wikibase/repo/includes/EditEntity.php(491): Wikibase\EntityContent->save('/* wbsetentity ...', Object(User), 81, 0, Object(Wikibase\EditEntity))
#9 /usr/local/apache/common-local/php-1.21wmf5/extensions/Wikibase/repo/includes/api/ApiModifyEntity.php(238): Wikibase\EditEntity->attemptSave('/* wbsetentity ...', 17, 'd55aee68b8d2da7...')
#10 /usr/local/apache/common-local/php-1.21wmf5/includes/api/ApiMain.php(825): Wikibase\ApiModifyEntity->execute()
#11 /usr/local/apache/common-local/php-1.21wmf5/includes/api/ApiMain.php(372): ApiMain->executeAction()
#12 /usr/local/apache/common-local/php-1.21wmf5/includes/api/ApiMain.php(349): ApiMain->executeActionWithErrorHandling()
#13 /usr/local/apache/common-local/php-1.21wmf5/api.php(77): ApiMain->execute()
#14 /usr/local/apache/common-local/live-1.5/api.php(3): require('/usr/local/apac...')
#15 {main}
Comment 2 Aude 2012-12-06 22:52:30 UTC
Reedy says we are still getting these errors.

 Thu Dec 6 21:50:03 UTC 2012     srv257  wikidatawiki    Wikibase\TermSqlCache::saveTermsOfEntity        10.0.6.44       1213    Deadlock found when trying to get lock; try restarting 
               transaction (10.0.6.44)  INSERT  INTO `wb_terms` (term_language,term_type,term_text,term_entity_id,term_entity_type) VALUES ('eo','label','Kalvinana preÄ
Comment 3 Sam Reed (reedy) 2012-12-06 22:54:01 UTC
*** Bug 42798 has been marked as a duplicate of this bug. ***
Comment 4 Rob Lanphier 2012-12-10 22:54:22 UTC
This is kind of a big deal to leave like this.  Who is working on this, and what's the status?
Comment 5 Daniel Kinzler 2012-12-11 10:57:24 UTC
@Rob: I'm working on it. Upping prio.
Comment 6 jeblad 2012-12-11 16:25:47 UTC
Change I2e8d2fa7: (bug 42547) avoid deadlocks by using retry loop
Comment 7 Daniel Kinzler 2012-12-11 16:31:55 UTC
Change I442ee8df: (bug 42547) don't re-save terms if nothing changed
Comment 8 Anja Jentzsch 2012-12-12 09:04:44 UTC
Changes have been merged.
Comment 9 abraham.taherivand 2012-12-12 16:36:32 UTC
Verified in Wikidata demo sprint 26

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links