Last modified: 2014-10-15 12:49:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44507, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42507 - ExternalChangesLine technical debt
ExternalChangesLine technical debt
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2012-11-28 16:16 UTC by Jeroen De Dauw
Modified: 2014-10-15 12:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jeroen De Dauw 2012-11-28 16:16:37 UTC 
ExternalChangesList has no documentation on what it's supposed to be and class-orientated (ie everything is static). It also has a 120+ line method that should probably be split up.
Comment 1 Jeroen De Dauw 2012-11-28 16:44:35 UTC 
It also has no tests.
Comment 2 Daniel Kinzler 2012-11-30 16:08:31 UTC 
From the looks of it, it's a utility class for constructing changes entries on on RecentChanges and the watchlist. Unit testing this will probably just be a bunch of regular expressions against the output, but we should have that anyway.
Comment 3 Lydia Pintscher 2013-10-08 17:12:47 UTC 
Still relevant?
Comment 4 Jeroen De Dauw 2013-10-08 18:19:17 UTC 
Yes. Looks like this code has not been improved upon. Also still lacks tests for basically everything.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links