Last modified: 2014-10-15 12:49:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 42507 - ExternalChangesLine technical debt
ExternalChangesLine technical debt
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2012-11-28 16:16 UTC by Jeroen De Dauw
Modified: 2014-10-15 12:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jeroen De Dauw 2012-11-28 16:16:37 UTC
ExternalChangesList has no documentation on what it's supposed to be and class-orientated (ie everything is static). It also has a 120+ line method that should probably be split up.
Comment 1 Jeroen De Dauw 2012-11-28 16:44:35 UTC
It also has no tests.
Comment 2 Daniel Kinzler 2012-11-30 16:08:31 UTC
From the looks of it, it's a utility class for constructing changes entries on on RecentChanges and the watchlist. Unit testing this will probably just be a bunch of regular expressions against the output, but we should have that anyway.
Comment 3 Lydia Pintscher 2013-10-08 17:12:47 UTC
Still relevant?
Comment 4 Jeroen De Dauw 2013-10-08 18:19:17 UTC
Yes. Looks like this code has not been improved upon. Also still lacks tests for basically everything.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links