Last modified: 2013-04-22 16:16:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44461, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42461 - No database class but LoadBalancer.php:741 has $conn = new Database
No database class but LoadBalancer.php:741 has $conn = new Database
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.21.x
All All
: High normal (vote)
: ---
Assigned To: Platonides
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2012-11-26 21:52 UTC by Platonides
Modified: 2013-04-22 16:16 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2012-11-26 21:52:52 UTC 
We don't have a class called Database, but on line 741 of LoadBalancer we have:
	$conn = new Database;

Admittedly, just to pass it to DBConnectionError constructor:
	throw new DBConnectionError( $conn, $this->mLastError );

but it won't reach there since it will generate a fatal first.
Comment 1 Platonides 2013-01-26 15:41:42 UTC 
Fix in changeset 45941
Comment 2 Platonides 2013-01-26 15:41:58 UTC 
Gerrit change #45941
Comment 3 db [inactive,noenotif] 2013-03-26 20:31:50 UTC 
(In reply to comment #2)
> Gerrit change #45941

Status Merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links