Last modified: 2013-07-12 19:13:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44267, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 42267 - PHP Strict Standards: Static function 'getSoftwareLink' should not be abstract
PHP Strict Standards: Static function 'getSoftwareLink' should not be abstract
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.21.x
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2012-11-19 18:59 UTC by Sam Reed (reedy)
Modified: 2013-07-12 19:13 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-11-19 18:59:00 UTC 
PHP Strict Standards: Static function 'getSoftwareLink' should not be abstract

Line 192 of Database.php
Comment 1 Platonides 2013-01-26 22:43:33 UTC 
Why not?

Are static functions incompatible with being abstract?
We want the dbs to have such static function, so having it in the interface seems the right thing to do.
Comment 2 Sam Reed (reedy) 2013-01-26 23:07:07 UTC 
(In reply to comment #1)
> Why not?
> 
> Are static functions incompatible with being abstract?
> We want the dbs to have such static function, so having it in the interface
> seems the right thing to do.

http://stackoverflow.com/questions/999066/why-does-php-5-2-disallow-abstract-static-class-methods
Comment 3 Platonides 2013-01-26 23:14:05 UTC 
From that link «As of PHP 5.2.x, only interfaces can have them.» We do have it in an interface, not as abstract...
Comment 4 Umherirrender 2013-07-12 19:13:41 UTC 
already changed with Gerrit change #63824
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links