Last modified: 2013-04-22 16:14:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44211, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42211 - Group membership log messages sometimes miss new membership status
Group membership log messages sometimes miss new membership status
Product: MediaWiki
Classification: Unclassified
Logging (Other open bugs)
All All
: Unprioritized normal (vote)
: ---
Assigned To: Alex Monk
: 42411 42418 43538 (view as bug list)
Depends on:
Blocks: SWMT
  Show dependency treegraph
Reported: 2012-11-16 22:48 UTC by MA
Modified: 2013-04-22 16:14 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description MA 2012-11-16 22:48:39 UTC

Please have a look, for example, at <>.

10:41, 16 November 2012 Matanya (talk | contribs | block) changed group membership for User:דורית@hewiki from bureaucrat and administrator to [missing new status of the user] (reason).

Also other example: <>

22:16, 14 November 2012 Vituzzu (talk | contribs | block) changed group membership for User:Vituzzu@itwiki from bureaucrat, flooder and administrator to bureaucrat and [?? missing] (fatto)

Userrights log messages are not completing for unknown reasons, leaving those messages incomplete thus not allowing to know which rights have changed.

Thanks. Regards.
Comment 1 Alex Monk 2012-11-17 15:31:06 UTC
Appears to be to do with RightsLogFormatter::getMessageParameters, Language::listToText, and $newGroups array keys not starting at 0 on some entries. Moving to MediaWiki product.
Comment 2 Alex Monk 2012-11-17 15:35:01 UTC
This hack fixes it for me:
diff --git a/includes/logging/LogFormatter.php b/includes/logging/LogFormatter.php
index 8c1e294..26368b4 100644
--- a/includes/logging/LogFormatter.php
+++ b/includes/logging/LogFormatter.php
@@ -1108,7 +1108,7 @@ class RightsLogFormatter extends LogFormatter {
                        $params[3] = $this->msg( 'rightsnone' )->text();
                if ( count( $newGroups ) ) {
-                       $params[4] = $lang->listToText( $newGroups );
+                       $params[4] = $lang->listToText( array_values( $newGroups ) );
                } else {
                        $params[4] = $this->msg( 'rightsnone' )->text();
Comment 3 MA 2012-11-17 19:51:33 UTC
Changed summary, as it's happening too on


22:42, 14 November 2012 Trijnstel (talk | contribs | block) changed group membership for User:ShinePhantom from OTRS member, autopatroller and file mover to OTRS member and [**missing**](OTRS members are already autopatrolled).

Comment 4 Alex Monk 2012-11-17 20:43:28 UTC
Gerrit change #33878
Comment 5 Alex Monk 2012-11-24 15:22:54 UTC
*** Bug 42411 has been marked as a duplicate of this bug. ***
Comment 6 Alex Monk 2012-11-24 22:24:09 UTC
*** Bug 42418 has been marked as a duplicate of this bug. ***
Comment 7 Alex Monk 2012-12-12 18:36:07 UTC
Merged by Roan.
Comment 8 Alex Monk 2012-12-31 15:20:32 UTC
*** Bug 43538 has been marked as a duplicate of this bug. ***
Comment 9 MA 2012-12-31 17:09:24 UTC
I see this "Resolved - Fixed" and "Merged" in comment 7 but the problem still happens. Is the code working in the server or awaiting commit?

From meta rights' log:

* 11:05, 31 December 2012 Vituzzu (talk | contribs) changed group membership for User:Vituzzu@itwiktionary from CheckUser and patroller to (done)

Thanks (& happy new year)
Comment 10 Alex Monk 2012-12-31 17:10:20 UTC
It's fixed, but WMF haven't updated their version of the software to include the patch yet.
Comment 11 Alex Monk 2012-12-31 17:14:50 UTC
You can see their schedule here:
(It should be in 1.21wmf7)

Note You need to log in before you can comment on or make changes to this bug.