Last modified: 2013-03-19 21:34:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43889, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41889 - tablesorter has trouble exploding rowspans with row header cells
tablesorter has trouble exploding rowspans with row header cells
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.21.x
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks: 31601
  Show dependency tree / graph
 
Reported: 2012-11-08 13:38 UTC by Derk-Jan Hartman
Modified: 2013-03-19 21:34 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2012-11-08 13:38:06 UTC 
Example https://en.wikipedia.org/w/index.php?title=2012_in_film&oldid=521959220

this probably goes wrong because the cell that needs exploding is a TH instead of a TD.
Comment 2 Bartosz Dziewoński 2012-11-16 22:00:57 UTC 
Fixed by Ibe4cc7e9.
Comment 3 Brad Jorsch 2012-11-19 17:54:04 UTC 
(In reply to comment #2)
> Fixed by Ibe4cc7e9.

No, it wasn't. That fixes a different bug.

A minimal test case for this bug seems to be the following table

{| class="wikitable sortable"
|-
! foo !! bar !! baz !! n
|-
!rowspan=2| foo
|rowspan=2| bar
| baz || 1
|-
| baz || 2
|}

When the rowspans are exploded, both rows should have "foo" in the first cell, "bar" in the second, and "baz" in the third. But currently the second row will get "baz" in the second cell and "bar" in the third.

Gerrit change #34104 should fix it, plus a number of similar problems when row or colspans are used in creative ways.
Comment 4 Andre Klapper 2012-11-30 12:14:26 UTC 
Brad: Could you add some potential reviewers in https://gerrit.wikimedia.org/r/#/c/34104/ ?
Comment 5 Brad Jorsch 2012-11-30 13:43:50 UTC 
Done. I seldom know who exactly to add, so I usually forget.
Comment 6 Gerrit Notification Bot 2013-03-07 22:31:06 UTC 
https://gerrit.wikimedia.org/r/34104 (Gerrit Change Icb674f7eece053435ca9525d45709579df14cc74) | Code-Review: Reviewed:+2 Patch Set 8: Code-Review+2

OK, it can be merged, then. I would do it myself, except that the unit test file has a fairly large merge conflict. [by com.google.gerrit.server.events.AccountAttribute@54cf85f]
Comment 7 Gerrit Notification Bot 2013-03-07 22:34:27 UTC 
https://gerrit.wikimedia.org/r/34104 (Gerrit Change Icb674f7eece053435ca9525d45709579df14cc74) | Patch Set 8: -Verified

Starting gate-and-submit jobs.
http://integration.mediawiki.org/zuul/status [by com.google.gerrit.server.events.AccountAttribute@ac7e4af]
Comment 8 Gerrit Notification Bot 2013-03-07 22:34:39 UTC 
https://gerrit.wikimedia.org/r/34104 (Gerrit Change Icb674f7eece053435ca9525d45709579df14cc74) | Code-Review: Verified:-1 Patch Set 8: Verified-1

Build failed

This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. [by com.google.gerrit.server.events.AccountAttribute@f5c901c]
Comment 9 Greg Grossmeier 2013-03-19 21:34:06 UTC 
This is merged in -wmf12 and -wmf12 is in the process of being deployed across all WMF sites (should be done by end of next week). Closing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links