Last modified: 2013-02-08 20:50:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43771, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41771 - disable SVG rasterizing
disable SVG rasterizing
Status: RESOLVED DUPLICATE of bug 3593
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-04 19:27 UTC by Joe ST
Modified: 2013-02-08 20:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
hack that fixes this bug on my wiki (7.27 KB, patch)
2012-11-23 21:03 UTC, Joe ST
Details
hacks to v1.20.2 specificlally (1.69 KB, patch)
2012-12-15 15:44 UTC, Joe ST
Details

Description Joe ST 2012-11-04 19:27:08 UTC
I am running in safe_mode, and am having trouble with thumbnails. I have $wgUseImageResize = false; so that I can use all my already-rasterized images, but I have no way of disabling the SVG rasterizer, and yet still being able to view the image itself (aka an img tag with src="something.svg"). I don't want to support old browsers. How can I fix this?
Comment 1 Jesús Martínez Novo (Ciencia Al Poder) 2012-11-04 19:37:53 UTC
Since most major browsers already support SVG [1] it seems sensible enough that we provide a configuration variable so SVG images are embedded directly in articles just as any other images, without the need to generate a rasterized thumbnail.

Although I'm not sure if that would eliminate the need of a SVG converter to retrieve the file dimensions and get the proper aspect ratio for generating width and height of the image. Maybe we could get it directly from the svg markup.


[1] = http://en.wikipedia.org/wiki/Scalable_Vector_Graphics#Support_for_SVG_in_web_browsers
Comment 2 Joe ST 2012-11-23 21:03:20 UTC
Created attachment 11414 [details]
hack that fixes this bug on my wiki
Comment 3 Bawolff (Brian Wolff) 2012-11-24 19:10:08 UTC
(In reply to comment #1)

> Although I'm not sure if that would eliminate the need of a SVG converter to
> retrieve the file dimensions and get the proper aspect ratio for generating
> width and height of the image. Maybe we could get it directly from the svg
> markup.
> 
> 

We actually already get that directly from the file actually, so that's not really an issue.

----

Main issues for doing this:
*Having svgs directly on the page is scarier from a security prespective [There might already be work to dissallow scripted svgs. I can't remember. I would assume so]
*Different browsers implement svg rendering differently. Some users might not like it looks different to different people
Comment 4 MZMcBride 2012-11-24 19:27:14 UTC
Copying Brion on this bug.

I believe current support for this type of functionality (serving SVGs directly to users/browsers) is being packaged in a MediaWiki extension, but perhaps it should be moved into core.
Comment 5 Joe ST 2012-12-15 15:44:40 UTC
Created attachment 11520 [details]
hacks to v1.20.2 specificlally

rather than patching from 1.19.1 + hacks to 1.20.1
Comment 6 Joe ST 2012-12-15 15:46:08 UTC
@MZMcBride well, considering the size of the hack, I don't see how it is viable as an extension.
Comment 7 Bawolff (Brian Wolff) 2012-12-15 22:05:35 UTC
note there are extensions of all sizes, ranging from 2 lines to tens of thousands of lines or more.
Comment 8 Joe ST 2012-12-15 22:24:07 UTC
it was more that its fixable in the main with a small amount of code, which would be greatly expanded to make it into a plugin, surely.
Comment 9 Jesús Martínez Novo (Ciencia Al Poder) 2013-02-08 20:50:13 UTC
Whoops, this petition already exists as bug 3593

@Joe ST : You may want to post your patch there

*** This bug has been marked as a duplicate of bug 3593 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links