Last modified: 2014-01-06 02:41:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43324, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41324 - Collection and ProofreadPage in Wikisource sometimes create nearly empty PDF files
Collection and ProofreadPage in Wikisource sometimes create nearly empty PDF ...
Status: NEW
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n, testme
Depends on: 21653
Blocks: 31552 Wikisource
  Show dependency treegraph
 
Reported: 2012-10-23 20:46 UTC by Pavel Selitskas [wizardist]
Modified: 2014-01-06 02:41 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Generated PDF (3.05 MB, application/pdf)
2013-01-05 01:48 UTC, Marcin Cieślak
Details
Generated PDF (be.wikisource) (56.55 KB, application/pdf)
2013-01-05 12:46 UTC, Pavel Selitskas [wizardist]
Details

Description Pavel Selitskas [wizardist] 2012-10-23 20:46:48 UTC
It seems to me that you can compile a book from a ProofreadPage-driven page (i.e. created by means of <pages /> tag) only in English Wikisource.

I don't know why exactly, but it's not a font problem :) (I checked against Belarusian, Deutsch and Russian Wikisource, neither works.)

I didn't dig deep into the Collection code, but the only fundamental difference between English setup and Belarusian/German/Russian setup is the naming of ProofreadPage namespaces (Author, Page & Index). But all of the tested Wikisource projects (be, de, ru) have $wgNamespaceAliases set up to fall back to the English variant.

So, this is either Collection doesn't follow wgNamespaceAliases rules, or there is something way more complicated (that is why I post this bug here, and not in the Wikimedia section).

== Way to reproduce (in dewikisource) ==
1. Get a page with text from ProofreadPage extension - https://de.wikisource.org/wiki/Ah_%E2%80%93_Bah!
2. Click 'Drucken/exportieren -> Als PDF herunterladen'
3. Wait until the PDF is done.
4. Download it: Dokument herunterladen
5. ...
6. PROFIT! You can see nothing but a title and some rubbish, but not the actual text.
Comment 1 Sam Reed (reedy) 2012-10-23 21:05:13 UTC
It sounds very configuration orientated
Comment 2 Andre Klapper 2012-12-14 16:59:36 UTC
Pavel: Can you still reproduce? I cannot:

(In reply to comment #0)
> 1. Get a page with text from ProofreadPage extension -
> https://de.wikisource.org/wiki/Ah_%E2%80%93_Bah!

That page is empty and doesn't provide the "Print/export" option.

I tried https://de.wikisource.org/wiki/Seite:Topographia_Circuli_Burgundici_%28Merian%29_215.jpg (not yet proof-read) and didn't face any issues.

I tried https://de.wikisource.org/wiki/Seite:Literarischer_Verein_Stuttgart_IX_122.png (proof-read once) and it also worked correctly.


Looking at https://noc.wikimedia.org/conf/InitialiseSettings.php.txt this problem would have to happen on every wikisource project:
'wmgUseProofreadPage' => 
        'wikisource' => true,
'wmgUseCollection' => 
	'wikisource' => true, # 2009-02-24
so I'd expect more bug reports if this was still a problem?
Comment 3 Pavel Selitskas [wizardist] 2012-12-14 21:00:33 UTC
Hi, Andre.

You did the steps wrong to reproduce it. First of all, this is a concern of <pages/>, not the Page: namespace itself. I was trying to get a PDF of _compiled_ book (by means of <pages/>, in the main namespace), and you tested it agains non-embedded pages from Page: namespace.

Secondly, please be tolerant to Bugzilla's link parser :( The link for Ah - Bah! includes the exclamation sign, so please copy it with the exclamation sign.

Thirdly, I noticed that in Belarusian Wikisource, I can get a proper PDF with true contents, if _every_ included page is marked Validated (green). If there are proofread only (yellow) pages, or even lower level, then it fails and gives me a page with nothing, but license data.

To conclude, I can say that it's not NOT working at all, but it's either a bug, or some undocumented(?) behaviour (showing nothing in PDF if at least one non-validated page) which I personally find wrong. Anyway, I can't reproduce the same in English Wikisource, it renders a proper PDF regardless of page status.
Comment 4 Marcin Cieślak 2013-01-05 01:48:42 UTC
Created attachment 11591 [details]
Generated PDF

Generated PDF file
Comment 5 Marcin Cieślak 2013-01-05 01:49:51 UTC
I generated the above PDF from

https://pl.wikisource.org/w/index.php?title=Wniosek_w_sprawie_ACTA

this file contains <pages/> and is rendered from the pages in the index. I can see that pages at different approval level (green, yellow, red) are also included.
Comment 7 Andre Klapper 2013-04-26 12:02:34 UTC
de Testcase in comment 0 works for me, the poem is included in the PDF file.

I can still reproduce the problem in
https://be.wikisource.org/wiki/%D0%93%D0%B5%D0%BE%D0%B3%D1%80%D0%B0%D1%84%D1%96%D1%8F_%D0%AD%D1%9E%D1%80%D0%BE%D0%BF%D1%8B/%D0%9F%D0%B0%D1%9E%D0%B4%D0%BD%D1%91%D0%B2%D0%B0%D1%8F_%D0%AD%D1%9E%D1%80%D0%BE%D0%BF%D0%B0

I wonder if this might be an I18N issue instead.
Comment 8 Pavel Selitskas [wizardist] 2013-06-30 21:07:43 UTC
(In reply to comment #7)
> de Testcase in comment 0 works for me, the poem is included in the PDF file.
> 
> I can still reproduce the problem in
> https://be.wikisource.org/wiki/
> %D0%93%D0%B5%D0%BE%D0%B3%D1%80%D0%B0%D1%84%D1%96%D1%8F_%D0%AD%D1%9E%D1%80%D0%
> BE%D0%BF%D1%8B/
> %D0%9F%D0%B0%D1%9E%D0%B4%D0%BD%D1%91%D0%B2%D0%B0%D1%8F_%D0%AD%D1%9E%D1%80%D0%
> BE%D0%BF%D0%B0
> 
> I wonder if this might be an I18N issue instead.

Deutsch testcase has changed since then: all pages are verified now (status: green). When every included page is 'green', you get a proper PDF. Otherwise you get rubbish.

If bug 47596 is deployed, then perhaps this bug has nothing commong wil i18n.
Comment 9 Nemo 2013-08-10 10:06:34 UTC
Why is this in site requests?

(In reply to comment #8)
> Deutsch testcase has changed since then: all pages are verified now (status:
> green). When every included page is 'green', you get a proper PDF. Otherwise
> you get rubbish.

What was the previous colour? If it's red, the page doesn't actually exist; it's just magically preloaded and displayed by ProofreadPage *as if* is existed.
Comment 10 Pavel Selitskas [wizardist] 2013-08-10 10:31:25 UTC
(In reply to comment #9)
> Why is this in site requests?

I guess it is because it seemed like a configuration issue.

> 
> (In reply to comment #8)
> > Deutsch testcase has changed since then: all pages are verified now (status:
> > green). When every included page is 'green', you get a proper PDF. Otherwise
> > you get rubbish.
> 
> What was the previous colour? If it's red, the page doesn't actually exist;
> it's just magically preloaded and displayed by ProofreadPage *as if* is
> existed.

No, the status is greenish. Try this: https://be.wikisource.org/wiki/%D0%96%D1%8B%D0%B4%D1%8B_%D0%BD%D0%B0_%D0%91%D0%B5%D0%BB%D0%B0%D1%80%D1%83%D1%81%D1%96

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links