Last modified: 2013-08-31 22:33:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41402, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39402 - Add two new statuses to the workflow: patch released and patch committed.
Add two new statuses to the workflow: patch released and patch committed.
Status: RESOLVED DUPLICATE of bug 53387
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 40985 (view as bug list)
Depends on: 17322
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-15 23:01 UTC by matanya
Modified: 2013-08-31 22:33 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description matanya 2012-08-15 23:01:59 UTC
Please add those statuses to bugzilla for easier track of real bug status.

Some dev change the status to resolved fixed when the push the fix to gerrit for code review, some don't change it until a merge, and some forget at all.

The suggestion is to have fix released at patch being in code review and fix committed at merge. 

after the patch is live bug can move to resolved fixed. 

to change in bugzilla: administration -->  field values --> Status -->Add a value. 

Thanks
Comment 1 Liangent 2012-08-15 23:07:06 UTC
and there can be a bot to move patch-released to resolved-fixed after some time?
Comment 2 matanya 2012-08-15 23:07:44 UTC
I'm planning to write one.
Comment 3 Sam Reed (reedy) 2012-08-16 16:37:28 UTC
I'm not quite sure how necessary this is needed. Some people use fixed at commit/review, and then mark it verified when it's testable live.


This needs discussing on wikitech-l/mediawiki-l before adding new states
Comment 4 Andre Klapper 2012-08-28 15:12:52 UTC
As I already wrote in https://www.mediawiki.org/wiki/Thread:Talk:Git/Workflow/Bugzilla :

bugs.merproject.org and bugs.meego.com have a workflow with an additional step that might help clarifying things: RESOLVED FIXED (patch merged/committed to codebase) -> RELEASED (fix included in tarball [or deployed in case of the WFM instance?]) -> VERIFIED (reporter checked that commit actually fixed the issue).
Comment 5 Andre Klapper 2012-11-13 14:22:28 UTC
(In reply to comment #1)
> there can be a bot to move patch-released to resolved-fixed after some time?

Also see http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064317.html

> after the patch is live bug can move to resolved fixed

That's very Wikimedia specific while commits go also into MediaWiki.

To me, RESOLVED FIXED == patch has been merged, not necessarily deployed on a website (like Wikimedia), so I disagree with a "patch committed" status.
Comment 6 Andre Klapper 2013-03-18 13:45:08 UTC
To reevaluate after (In reply to comment #0)
> Some dev change the status to resolved fixed when the push the fix to gerrit
> for code review

That cannot be FIXED because nobody knows yet if that code change fixes the bug or even works. Hence this part is a no-go to me. WONTFIX.

> have fix released at patch being in code review

Some status like "patch in gerrit" could be considered, but only after bug 17322 is fixed. Such a status should preferably be set automatically, hence adding dependency.

> and fix committed at merge.

Fix committed means RESOLVED FIXED nowadays.
Comment 7 Andre Klapper 2013-03-18 14:28:09 UTC
*** Bug 40985 has been marked as a duplicate of this bug. ***
Comment 8 Quim Gil 2013-03-18 15:51:29 UTC
Once we have a process agreed let's remember to document or link it at 

https://www.mediawiki.org/wiki/Gerrit/Tutorial

Currently the only references to Bugzilla there are:

** Push your change set to Gerrit
... If your commit addresses a bug in Bugzilla, please comment on that bug to note that the commit is in the merge queue, and link to its changeset in Gerrit.

** Comparing patch sets
... If you merge a commit that references a Bugzilla bug, please go to that bug and mark it RESOLVED: FIXED and reference the merge ID.
Comment 9 Andre Klapper 2013-08-31 22:28:41 UTC
> patch released

The Gerrit Notification Bot automatically set the status PATCH_TO_REVIEW and adds a comment, so I consider this part of the request FIXED.

> patch committed

This means that the patch got merged. The Gerrit Notification Bot automatically adds a comment, but I am currently not yet convinced whether we should automatically close as RESOLVED FIXED.
The discussion about this takes place in bug 53387, so I am marking this as a duplicate.

*** This bug has been marked as a duplicate of bug 53387 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links