Last modified: 2012-08-12 08:05:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41233, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39233 - direction of justtranslated is not set according to the language
direction of justtranslated is not set according to the language
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
All All
: Unprioritized normal (vote)
: ---
Assigned To: Niklas Laxström
: i18n
Depends on:
Blocks: rtl
  Show dependency treegraph
Reported: 2012-08-10 15:11 UTC by Amir E. Aharoni
Modified: 2012-08-12 08:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Amir E. Aharoni 2012-08-10 15:11:35 UTC
The "justtranslated" feature in quickedit.js is very nice, except it doesn't apply the right direction to the result.

I tried to fix it myself, but couldn't find an easy way to get the direction from the language code. Apparently, there is not obvious way to do something like Language::factory() and Language::getDir() in MediaWiki's JavaScript, but maybe I missed something.
Comment 1 Amir E. Aharoni 2012-08-10 15:48:02 UTC
A simplistic fix here:

It just applies dir="auto", but should apply proper direction.

If there's no dynamic way to find the direction, maybe it can be taken from the translating <textarea> somehow, but I'm not sure how.
Comment 2 matanya 2012-08-12 08:05:33 UTC
patch merged.

Note You need to log in before you can comment on or make changes to this bug.