Last modified: 2014-09-14 11:11:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41025, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39025 - Gadgets 2.0: "hidden" doesn't work
Gadgets 2.0: "hidden" doesn't work
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: gadgets-2.0
  Show dependency tree / graph
 
Reported: 2012-08-04 00:52 UTC by Helder
Modified: 2014-09-14 11:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2012-08-04 00:52:56 UTC 
From
https://www.mediawiki.org/wiki/Thread:Talk:ResourceLoader/V2_testing/Unable_to_hide_a_gadget


The "hidden" option is not working for this gadget[1]. It appears on [2] even after I hide it[3]. Indeed, the loop[4] which adds a preference for each gadget doesn't check for its hidden property before adding it to Special:Preferences (BTW: it also doesn't check if the user has the appropriate rights).

[1] http://rl2.wmflabs.org/rl2-repo1/wiki/Gadget_definition:test.js
[2] http://rl2.wmflabs.org/rl2-repo1/wiki/Special:Preferences#mw-prefsection-gadgets Special:Preferences#mw-prefsection-gadgets
[3] http://rl2.wmflabs.org/rl2-repo1/w/index.php?title=Gadget_definition:test.js&diff=prev&oldid=462
[4] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Gadgets.git;a=blob;f=Gadgets.hooks.php;hb=refs/heads/RL2#l305
Comment 1 Kunal Mehta (Legoktm) 2014-09-14 11:11:43 UTC 
Confirming that this bug is still present.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links