Last modified: 2013-12-15 16:02:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40474, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38474 - Mixed directionality of AFT
Mixed directionality of AFT
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Matthias Mullie
: i18n
Depends on:
Blocks: 28708 39043
  Show dependency treegraph
 
Reported: 2012-07-18 15:02 UTC by Derk-Jan Hartman
Modified: 2013-12-15 16:02 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Current layout (both AFT and AFT5) (243.28 KB, image/png)
2012-07-19 09:07 UTC, Derk-Jan Hartman
Details
My en.wp improved layout (237.13 KB, image/png)
2012-07-19 09:07 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2012-07-18 15:02:17 UTC
AFT draws user interface elements into the content area and should thus take some extra care because it needs to operate in mixed directionality environments.

I had to add this: https://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=502968441&oldid=502956030

To make it behave a bit nicer when the (ltr) content has right floating elements.
Example: https://en.wikipedia.org/wiki/Qarabagh,_Afghanistan?uselang=fa (with applied fix, so use your inspector to check out the original situation).
Comment 1 Fabrice Florin 2012-07-18 15:43:52 UTC
Thanks, Derk-Jan, good point.

We'll look into your recommendation shortly.

If you submit more bugs in the future, I recommend you add 'aftv5-1.5' in the Keyword field, which will bring them up to our attention for this phase.
Comment 2 Derk-Jan Hartman 2012-07-19 09:05:43 UTC
Well I wouldn't recommend this solution, it is just what was needed to improve the current situation. There is probably a better solution that will work for both LTR and RTL content, but it requires a bit of experimentation.
Comment 3 Derk-Jan Hartman 2012-07-19 09:07:31 UTC
Created attachment 10859 [details]
Current layout (both AFT and AFT5)
Comment 4 Derk-Jan Hartman 2012-07-19 09:07:54 UTC
Created attachment 10860 [details]
My en.wp improved layout
Comment 5 Derk-Jan Hartman 2012-07-24 11:49:18 UTC
For a related issue in plain LTR mode see:

https://en.wikipedia.org/wiki/File:Lock_error_and_Article_Feedback_Tool_v5.png
Comment 6 Gerrit Notification Bot 2013-05-09 14:18:21 UTC
Related URL: https://gerrit.wikimedia.org/r/62978 (Gerrit Change I2f349df5c848bf36497ad383623b0daa71a2d3fb)
Comment 7 Gerrit Notification Bot 2013-12-15 16:02:26 UTC
Change 62978 merged by jenkins-bot:
(bug 38474) Mixed directionality of AFT

https://gerrit.wikimedia.org/r/62978

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links