Last modified: 2014-01-30 23:38:13 UTC
Gerrit revision lists would highly benefit from alternating row colors or highlighting of the hovered row.
With revision I mean patches.
I also learned that you can click the row, but this feature is not discoverable.
I have changed the bug summary which is really about using alternate colors on the changes list. Timo and Roan did some work to enhance Gerrit look'n feel, seems to be as easy as tweaking a CSS file.
My bet is that this requires change in gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable2.java and it's not an easy CSS change (CSS identifiers in GWT change on build) +upstream (not filed yet)
Actually, I think this will be handled as part of some recent UI changes by OpenStack: https://gerrit-review.googlesource.com/#/c/36560/
Do we have to make some changes to enable the colors?
We'll have to set two theme settings (tableOddRowColor & tableEvenRowColor). Blocked on the 2.5 upgraded. https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#_a_id_theme_a_section_theme
This is possible now, anyone have 2 colors in mind?
white / #DCDCDC ?
I'd like Timo's input, since he did most of the skinning work last time :) CC'd.
(In reply to comment #9) > white / #DCDCDC ? Slight different: #fff / #eee That way it matches our other white-alternating styles (label columns of info block, header of comment thread etc.)
Gerrit config tweak: https://gerrit.wikimedia.org/r/49993 Untested though.
The color alternance is applied by using a CSS selector :nth-child(odd) and :nth-child(even) on each of the table rows (tr). That is done via the .tableChange class. On a user dashboard view, the section headers and their changes are all part of the same global table which apply the .tableChange class. Given a previous section can get an odd or even number of changes, the first change in a section can in turn be either odd or even. Thus we could have the first change of a section to receive the same color as the header :( We might want to pick a different color to differentiate changes/headers or have the bug fixed upstream. Like pink for headers.
Created attachment 11812 [details] first change line having the same color as the header
(In reply to comment #0) > Gerrit patch lists would highly benefit from alternating row colors or > highlighting of the hovered row. Are you referring to the list of Pathes on a change page > Patch set 3 fd9d49c8 (gitweb) > Patch set 2 4772e9eb (gitweb) > Patch set 1 4ba628db (gitweb) etc. Or do you mean "change" lists, the list of changes as a result from a search query or the dashboard for example: > (*) | Change subject | Owner | Project | ... > (*) | Change subject | Owner | Project | ... > (*) | Change subject | Owner | Project | ...
This bug is about alternate change list row colors. So I guess changes and that is what have been implemented upstream. There is no such support for the list of patchset, I guess that should be an other bug.
Christian Aistleitner submitted a patch to upstream: https://gerrit-review.googlesource.com/#/c/42502/
That patch is still pending, by the way.