Last modified: 2013-12-11 08:33:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39836, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37836 - ProofreadPage uses too many global variables in JavaScript
ProofreadPage uses too many global variables in JavaScript
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2012-06-22 18:27 UTC by Jon
Modified: 2013-12-11 08:33 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2012-06-22 18:27:31 UTC
The proofread extension uses global variables. This is bad as it means other javascript extensions could possibly break it.

The javascript should attach itself to the mw object
e.g. mw.proofreadPage
Comment 1 Tpt 2013-12-11 08:33:23 UTC
All global variables have been removed

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links