Last modified: 2014-04-08 00:00:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39484, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37484 - [Regression] WikiEditor 'removeFromToolbar' API is broken
[Regression] WikiEditor 'removeFromToolbar' API is broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
master
All All
: Highest major (vote)
: ---
Assigned To: Krinkle
: code-update-regression
: 37842 (view as bug list)
Depends on:
Blocks: 37346
  Show dependency treegraph
 
Reported: 2012-06-12 08:12 UTC by Michael M.
Modified: 2014-04-08 00:00 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (11.32 KB, image/png)
2012-06-19 08:16 UTC, Michael M.
Details

Description Michael M. 2012-06-12 08:12:12 UTC
Steps to reproduce:

1. Open a page for editing.
2. Execute (copied from [1])
    /* Remove Search & Replace */
    $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
            'section': 'advanced',
            'group': 'search',
            'tool': 'replace'
    });

Result in 1.20wmf4: The button for search&replace is removed.
Result in 1.20wmf5: Nothing happens.

https://gerrit.wikimedia.org/r/#/c/9751/ changed the wrapping for buttons from <span> to <a> without changing it in the removeFromToolbar method, too.

[1] https://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization#Removing_things
Comment 1 Michael M. 2012-06-14 08:49:06 UTC
Raising importance: The API is used internally to replace the icons for <ref>, links and tables with the dialog versions. Since this bug, the icons for simple insertion are not removed, resulting e.g. in two identical looking icons for <ref>.

The icon for signature, which should be suppressed in namespace 0, is shown, too.
Comment 2 Michael M. 2012-06-19 08:16:16 UTC
I'm not sure why this bug is ignored, so setting importance to Highest.
This is a really annoying bug.
Comment 3 Michael M. 2012-06-19 08:16:44 UTC
Created attachment 10771 [details]
Screenshot
Comment 4 kipod 2012-06-22 18:47:39 UTC
*** Bug 37842 has been marked as a duplicate of this bug. ***
Comment 5 Eran Roz 2012-06-25 16:35:05 UTC
a bugfix (not merged yet) can be found here:
https://gerrit.wikimedia.org/r/#/c/12893/1
Comment 6 Krinkle 2012-06-25 18:46:26 UTC
(In reply to comment #5)
> a bugfix (not merged yet) can be found here:
> https://gerrit.wikimedia.org/r/#/c/12893/1

Thank you for that patch. Merged it.

1.20wmf6 was branched and deployed today. The next automatic update window for all extensions is 1.20wmf7, in 2 weeks. I'll see if this can be backported to wmf5 and wmf6. Shouldn't be an issue.

Anyway, marking this fixed.
Comment 7 Derk-Jan Hartman 2014-04-08 00:00:40 UTC
*** Bug 29440 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links