Last modified: 2014-10-28 20:41:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39120, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37120 - Special:Undelete on suppressed revisions
Special:Undelete on suppressed revisions
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
unspecified
All All
: Low minor with 2 votes (vote)
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-25 21:53 UTC by Alex Monk
Modified: 2014-10-28 20:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alex Monk 2012-05-25 21:53:20 UTC
https://www.mediawiki.org/w/index.php?title=Special:Undelete&target=Uitest&timestamp=20120525212653

This revision was suppressed, but the text claims that the details can be found in the deletion log, and uses a broken deletion log link.
Comment 1 Thehelpfulone 2012-05-26 21:33:45 UTC
Hmm, marking as low, I don't think it's a big deal, the suppression log is oversight only for a reason - what do you suggest to fix this bug?
Comment 2 Alex Monk 2012-05-27 13:47:00 UTC
It's not a big deal which is why I marked it as minor. I'm aware that it's suppressionlog-only for a reason, but you're missing the point. This text is shown to people without the permission, tells them that details can be found in the wrong log, and gives a broken link to the log.

So, for users able to see normal deleted revisions: "This page revision has been suppressed."

Or, if the user has the supressionlog permission, "This page revision has been suppressed. Details can be found in the suppression log." with a link to the suppression log for the page which the revision was on instead of the suppression log for Special:Undelete.
Comment 3 Thehelpfulone 2012-05-27 14:10:39 UTC
Ok, so I confirmed that if the user is an oversighter, they see 

One of the revisions of this diff has been suppressed. Details can be found in the suppression log. You can still view this diff if you wish to proceed.
Comment 4 Alex Monk 2012-12-23 22:38:32 UTC
Gerrit change #40283
Comment 5 Andre Klapper 2013-07-24 10:36:01 UTC
Patch in Gerrit needs review...
Comment 6 Gerrit Notification Bot 2013-08-11 13:49:20 UTC
Change 40283 had a related patch set uploaded by Nemo bis:
(bug 37120) Fix slightly broken behaviour with suppressed revisions on Special:Undelete

https://gerrit.wikimedia.org/r/40283

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links