Last modified: 2013-05-22 18:41:26 UTC
Special pages which usually cannot be edited (example: Special:Upload) with system messages which have sections "==" in it are rendered with section "[edit]" links. This does not make sense and should be repaired. For example, when you modify [[MediaWiki:Uploadtext]] and change the line + To include a file in a page, use a link in one of the following forms: to + == To include a file in a page, use a link in one of the following forms: == then the Special:Upload page is rendered with an "[edit]" link, which does not make sense. In my view, System messages which are uneditable should never be rendered with section "[edit]" links. Observed with https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;h=2f5914c2ce4c612920dd96f5ef66e3bd342d2195
Gerrit change #8016
Confirmed. Bisecting points to 7bfebad30875b852e1e70bde10dbd12fa3e8a673. Something similar was reported at that time (r70498), but it wasn't reproducible (and was indeed not shown in Wikipedia). I don't see where it is affected, since special pages aren't articles nor use the parser cache. The only difference in the popts on both revisions is mIsPrintable changing from NULL to false, a change which shouldn't matter. Ok, the problem appeared because the this->mTitle->quickUserCan() was never called, instead of being moved below. That block was then removed in r70499. After r92703 (d70ad8c), it wouldn't be possible to show the edit markers, since $popts->mEditSection would always be false. But then r86304 (3a0ed7) replaced $wgOut->parse() with MessageCache->parse(), which didn't have that provision. Patched in https://gerrit.wikimedia.org/r/8017
Marking as fixed since the change is now merged.
*** Bug 17046 has been marked as a duplicate of this bug. ***
