Last modified: 2013-07-06 14:56:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38966, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36966 - Word-ending links do not work in or/hi, update linktrail rules
Word-ending links do not work in or/hi, update linktrail rules
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: 1.22.0 release
Assigned To: Santhosh Thottingal
http://or.wikipedia.org
: i18n, patch, patch-need-review
Depends on:
Blocks: 41348
  Show dependency treegraph
 
Reported: 2012-05-19 07:27 UTC by ansuman
Modified: 2013-07-06 14:56 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ansuman 2012-05-19 07:27:06 UTC
Hello, Word-ending links does not work for or.wikipedia.
Its only working for English characters ex. [[ଓଡିଆ]]n but not for Odia ex. [[ଓଡିଆ]]ପ.

Also on hn.wikipedia for hindi chars [[चेन्नई]]क [[चेन्नई]]अ [[चेन्नई]]कि ....
Comment 1 ansuman 2012-05-19 16:32:05 UTC
Sorry, its hi.wikipedia not hn.wiki.
Comment 2 Jon Harald Søby 2012-07-27 01:27:12 UTC
I was able to fix this on my local MediaWiki installation. I have tried for _hours_ now to get git/gerrit properly set up to make a patch or whatever, but get a cavalcade of various error messages and am now officially giving up.

The fixes I have made are these:

In languages/messages/MessagesHi.php, change Line 176 to this:

  $linkTrail = "/^([a-zऀ-ॿ]+)(.*)$/sDu";

In languages/messages/MessagesOr.php, add this below Line 33:

  $linkTrail = "/^([a-zଁ-୷]+)(.*)$/sDu";


These fixes may not account for punctuation and/or other symbols that should not be included in the linktrail. For Hindi I used the characters in the standard Devanagari Unicode block, and the same for Oriya. I am not sure which symbols are punctuation, so this may not be correct. But it's better than nothing, I think (hope).
Comment 3 Nemo 2012-08-02 12:11:24 UTC
Clarified summary.

As a coincidence, I've just updated docs on linktrail at [[m:Help:Links]] and [[mw:Help:Links#linktrail]], where did you/would you look for this sort of info to understand how it works and how it can be localised? This feature is very poorly documented...
Comment 4 Jon Harald Søby 2012-08-02 13:58:40 UTC
(In reply to comment #3)
> Clarified summary.
> 
> As a coincidence, I've just updated docs on linktrail at [[m:Help:Links]] and
> [[mw:Help:Links#linktrail]], where did you/would you look for this sort of info
> to understand how it works and how it can be localised? This feature is very
> poorly documented...

It is a line in every languages/messages/MessagesXx.php file, starting with $linkTrail. It is defined as a simple regex, like in the fixes I posted above. For unicode languages, you have to add the minuscule "u" at the end of the regex.
Comment 5 Nemo 2012-08-04 11:17:08 UTC
(In reply to comment #4)
> It is a line in every languages/messages/MessagesXx.php file, starting with
> $linkTrail. It is defined as a simple regex, like in the fixes I posted above.
> For unicode languages, you have to add the minuscule "u" at the end of the
> regex.

Yes, I know this, but I'd like ansuman to give us some suggestions as where to put such info so that users find it.
Comment 6 Srikanth Logic 2012-08-13 05:38:22 UTC
(In reply to comment #2)
> I was able to fix this on my local MediaWiki installation. I have tried for
> _hours_ now to get git/gerrit properly set up to make a patch or whatever, but
> get a cavalcade of various error messages and am now officially giving up.
> 
> The fixes I have made are these:
> 
> In languages/messages/MessagesHi.php, change Line 176 to this:
> 
>   $linkTrail = "/^([a-zऀ-ॿ]+)(.*)$/sDu";
> 
> In languages/messages/MessagesOr.php, add this below Line 33:
> 
>   $linkTrail = "/^([a-zଁ-୷]+)(.*)$/sDu";
> 
> 
> These fixes may not account for punctuation and/or other symbols that should
> not be included in the linktrail. For Hindi I used the characters in the
> standard Devanagari Unicode block, and the same for Oriya. I am not sure which
> symbols are punctuation, so this may not be correct. But it's better than
> nothing, I think (hope).

These fixes did not work for me, is there anything else that needs to be done?


(In reply to comment #5)
> (In reply to comment #4)
> > It is a line in every languages/messages/MessagesXx.php file, starting with
> > $linkTrail. It is defined as a simple regex, like in the fixes I posted above.
> > For unicode languages, you have to add the minuscule "u" at the end of the
> > regex.
> 
> Yes, I know this, but I'd like ansuman to give us some suggestions as where to
> put such info so that users find it.

Niklas tells its intended to keep it so and make people request so that we don't break things.
Comment 7 Andre Klapper 2013-01-23 12:20:04 UTC
So I guess this needs a volunteer to take the fix from comment 2 and put it into Gerrit. See http://www.mediawiki.org/wiki/Developer_access for anybody interested.
Comment 8 ansuman 2013-01-23 12:48:10 UTC
(In reply to comment #5)
 
> Yes, I know this, but I'd like ansuman to give us some suggestions as where
> to
> put such info so that users find it.

I am not sure how you want me to give suggestions? Let me elaborate what I think you mean. 

Its simple, As we write "verb" "adverb" or "preposition" with Nouns in Odia, e.g. [[ଓଡ଼ିଆ]]ରେ , [[ଭାଷା]]ଗୁଡିକୁ . Often we write them together as one word. And the later part doesn't get linked to first part and it looks odd as it is seen in two different colors. 

Is this what you wanted to know Nemo ?
Comment 9 Gerrit Notification Bot 2013-05-27 05:57:37 UTC
Related URL: https://gerrit.wikimedia.org/r/65653 (Gerrit Change Ib1b233d227f33e77c212e67eee2aea64357e55ba)
Comment 10 Nemo 2013-05-29 09:54:21 UTC
(In reply to comment #9)
> Related URL: https://gerrit.wikimedia.org/r/65653 (Gerrit Change
> Ib1b233d227f33e77c212e67eee2aea64357e55ba)

The patch adds to linktrail *all* the characters listed in:
http://www.unicode.org/charts/PDF/U0900.pdf
http://www.unicode.org/charts/PDF/UA8E0.pdf
This includes, for instance, "। DEVANAGARI DANDA" and "॥ DEVANAGARI DOUBLE DANDA" ("Generic punctuation for scripts of India"). 

ansuman, is it ok? Please check those two PDF, otherwise we'll assume it's fine.
Comment 11 Santhosh Thottingal 2013-05-29 10:18:01 UTC
(In reply to comment #10)
> This includes, for instance, "। DEVANAGARI DANDA" and "॥ DEVANAGARI DOUBLE
> DANDA" ("Generic punctuation for scripts of India"). 


Excluded danda characters in latest patchset.
Comment 12 ansuman 2013-07-06 14:56:51 UTC
Hi, Apologies for late response. Yes it's working in Odia Wikipedia now, I haven't checked all the characters and in other languages though. Thanks a lot Nemo,  Santhosh T., Srikanth L., Jon, Andre. :)

(In reply to comment #10)
> (In reply to comment #9)
> > Related URL: https://gerrit.wikimedia.org/r/65653 (Gerrit Change
> > Ib1b233d227f33e77c212e67eee2aea64357e55ba)
> 
> The patch adds to linktrail *all* the characters listed in:
> http://www.unicode.org/charts/PDF/U0900.pdf
> http://www.unicode.org/charts/PDF/UA8E0.pdf
> This includes, for instance, "। DEVANAGARI DANDA" and "॥ DEVANAGARI DOUBLE
> DANDA" ("Generic punctuation for scripts of India"). 
> 
> ansuman, is it ok? Please check those two PDF, otherwise we'll assume it's
> fine.

Those PDF contain only Devanagari script, anyway it's working for Odia Wikipedia. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links