Last modified: 2012-12-16 01:59:09 UTC
History pages and many other places should use the new IP::prettifyIP() function proposed in Gerrit. Currently, they show in all caps and in expanded form (e.g. A:B:C:D:E:F:0:1).
Also see https://gerrit.wikimedia.org/r/#/c/7296/.
Created attachment 10642 [details] Update userLink to prettify ip addresses Aaron, I (finally) took a look into this, and made an update that I think is what you were looking for. It seems like all of the places where the IP is shown call Linker::userLink. So I think Prettifying the IP there would be the right way. But was that what you were thinking?
Yeah that looks reasonable.
Are these keywords right?
(In reply to comment #2) > Created attachment 10642 [details] > Update userLink to prettify ip addresses > > Aaron, I (finally) took a look into this, and made an update that I think is > what you were looking for. It seems like all of the places where the IP is > shown call Linker::userLink. So I think Prettifying the IP there would be the > right way. > > But was that what you were thinking? Can this go in gerrit?
In my unqualified opinion, it's much easier for the non-technical (i.e. the non-Bugzilla community people to understand "2001:0db8:0:0:0:0:1428:57ab" than it is to understand "2001:db8::1428:57". Cheers, Sven
Should be tested on PostgreSQL as its CIDR type already shortens IPv6 addresses. See also bug 37612.
Pushed the patch to gerrit: https://gerrit.wikimedia.org/r/#/c/17671/
Someone mentioned this in #wikipedia-en and I took a look at the changeset, and didn't see anything obvious, so: Will this move all currently existing User talk pages to the new location? And subsequently all relevant logs like block log, abusefilter log? I'm also wondering if this will break links like [[User talk:2602:306:CE3C:50E0:F8EA:4EB8:BC87:5CD1]]? If this will do all of that, then wow, great! If not, we have a problem...
