Last modified: 2012-05-04 19:56:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38401, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36401 - directionality of entries in the interlanguage links in the mobile app list must match each language
directionality of entries in the interlanguage links in the mobile app list m...
Status: VERIFIED FIXED
Product: Wikipedia App
Classification: Unclassified
Localization/Translation/Language (Other open bugs)
3.2 (iOS) / 1.2 (Android)
All All
: Unprioritized normal
: 1.2 release
Assigned To: Yuvi Panda
: i18n
Depends on:
Blocks: rtl-android
  Show dependency treegraph
 
Reported: 2012-05-02 05:49 UTC by Amir E. Aharoni
Modified: 2012-05-04 19:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2012-05-02 05:49:59 UTC
The directionality of all the entries in the list of interlanguage links in the mobile app is the same as the directionality of the interface language. So if the language of the app is set to Hebrew, all names of languages appear as right-to-left.

The right way to do it is to define the directionality of each line according to the directionality of the language name. All non-RTL languages must be explicitly set to LTR and all RTL languages must be explicitly set to RTL. Without this the order of letters will be incorrect.

There's also the question of alignment, which is separate from directionality. If the order of letters in the name "English" is correct, but it's aligned to right, it may not look so nice.

So you have several options. You can align the whole list according to the app's language, then if the app's language is Hebrew you get something like this:

   Afrikaans
     العربية
     Deutsch
     English
    Francais
       עברית
     Русский
       יידיש

You can align each line according to the language of that line:

Afrikaans
     العربية
Deutsch
English
Francais
       עברית
Русский
       יידיש

Or you can go crazy and center them:

 Afrikaans
  العربية
  Deutsch
  English
 Francais
   עברית
  Русский
   יידיש

But again, the question of alignment is secondary - it's just a matter of what looks nicer. The important thing is to set the *directionality* of each line correctly.
Comment 1 Yuvi Panda 2012-05-02 10:31:24 UTC
Fixed in https://github.com/wikimedia/WikipediaMobile/pull/226
Comment 2 Amir E. Aharoni 2012-05-02 10:49:56 UTC
Appears to be fixed, thank you.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links