Last modified: 2013-07-25 09:01:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38399, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36399 - Embed ProofreadPage images in CSS
Embed ProofreadPage images in CSS
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 46578
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-01 23:45 UTC by Sam Reed (reedy)
Modified: 2013-07-25 09:01 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-05-01 23:45:11 UTC
All ProofreadPage images are less than 2KB, which should mean most of these can be included/embedded in CSS files, rather than using code such as:

							label: mw.msg( 'proofreadpage-button-zoom-in-label' ),
							type: 'button',
							icon: mw.config.get( 'wgExtensionAssetsPath' ) + '/ProofreadPage/Button_zoom_in.png',


or

		$prev_link = $prev_title ? Linker::link( $prev_title,
			Html::element( 'img', array( 'src' => $path . '/leftarrow.png',
				'alt' =>  wfMsg( 'proofreadpage_prevpage' ), 'width' => 15, 'height' => 15 ) ),
			array( 'title' => wfMsg( 'proofreadpage_prevpage' ) ) ): '';
Comment 1 matanya 2012-08-12 05:46:17 UTC
gerrit change: https://gerrit.wikimedia.org/r/#/c/16482/
Comment 2 Andre Klapper 2013-01-23 13:16:44 UTC
[Patch in Gerrit got reviewed (and abandoned), hence resetting keyword]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links