Last modified: 2014-10-25 12:25:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 35534 - Free-form tagging in gerrit
Free-form tagging in gerrit
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
: 35535 60401 (view as bug list)
Depends on:
Blocks: 22596
  Show dependency treegraph
 
Reported: 2012-03-27 19:42 UTC by Nemo
Modified: 2014-10-25 12:25 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2012-03-27 19:42:50 UTC
As with CodeReview, to organize work. "Topic" can't be changed after commit.
Comment 1 Antoine "hashar" Musso (WMF) 2012-03-27 20:01:39 UTC
You can change the topic branch post commit, fetch the change and resubmit it using another topic name:

 git fetch gerrit refs/changes/<somechange> && git checkout FETCH_HEAD
 git push HEAD:refs/for/master/new_topic

Or something to possibly try out:

 git-review -d 12345
 # rename branch:
 git branch -m new_topic
 # submit
 git-review -f

git-review -f -n (dry run) should make that clear.
Comment 2 Antoine "hashar" Musso (WMF) 2012-03-27 20:02:39 UTC
This bug should be rephrased as "post merge tagging of commits in gerrit" if we want to be able to change the topic branch name.  But I think the issue is really about having the ability to use keywords.
Comment 3 Chad H. 2012-03-28 13:17:59 UTC
(In reply to comment #2)
> This bug should be rephrased as "post merge tagging of commits in gerrit" if we
> want to be able to change the topic branch name.  But I think the issue is
> really about having the ability to use keywords.

Which is an upstream issue and widely reported/desired.
Comment 4 Chad H. 2012-03-29 13:03:13 UTC
*** Bug 35535 has been marked as a duplicate of this bug. ***
Comment 5 Chad H. 2012-06-28 12:56:05 UTC
Resolving this LATER until upstream moves on it.
Comment 6 Nemo 2012-11-14 12:16:00 UTC
Switching from LATER to the second most relevant resolution for fear of information loss. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/65116
Comment 7 Andre Klapper 2012-11-21 14:26:57 UTC
(In reply to comment #3)
> Which is an upstream issue and widely reported/desired.

Forwarding / finding a ticket in https://code.google.com/p/gerrit/issues/ and pasting the link here welcome.
Comment 8 Nemo 2012-11-21 14:36:14 UTC
(In reply to comment #7)
> (In reply to comment #3)
> > Which is an upstream issue and widely reported/desired.
> 
> Forwarding / finding a ticket in https://code.google.com/p/gerrit/issues/ and
> pasting the link here welcome.

Already in URL field.
Comment 9 Andre Klapper 2012-11-21 15:31:24 UTC
Ah, thanks. This is not high priority however.
Comment 10 Nemo 2012-11-21 15:33:53 UTC
(In reply to comment #9)
> Ah, thanks. This is not high priority however.

Why? Please elaborate when doing such changes.
It has discussed on several threads in wikitech-l why this feature is absolutely needed to avoid breaking code and it needs to be implemented as soon as possible (ie as soon as upstream moves on it).
Comment 11 Andre Klapper 2012-11-24 21:02:18 UTC
> Please elaborate when doing such changes.

Well, you started with setting "high priority" without explaining. ;)

Comment 5 states that noone plans to spend time on fixing this in Wikimedia but that we wait for upstream. And that makes it defacto "lowest priority". Plus upstream report is still open.
Comment 12 Nemo 2012-11-24 21:15:54 UTC
(In reply to comment #11)
> > Please elaborate when doing such changes.
> 
> Well, you started with setting "high priority" without explaining. ;)

Yes, I assumed knowledge of past discussions because there are too many of them on the topic to even link them (and not all public or known to me either), e.g. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/61378

> Comment 5 states that noone plans to spend time on fixing this in Wikimedia but
> that we wait for upstream. And that makes it defacto "lowest priority". Plus
> upstream report is still open.

As I said, «as soon as possible (ie as soon as upstream moves on it)». When it's is available in gerrit, this has to be implemented immediately, so it's of high/highest priority although delayed; I've no idea how to mark it otherwise, not having LATER; "upstream" marks it as waiting anyway.

Besides, RobLa didn't completely rule out the possibility of WMF fixing the bug upstream as well in the future.
Comment 13 Andre Klapper 2012-11-24 23:32:34 UTC
I see. Thanks for explaining, I really appreciate it.
Comment 14 Quim Gil 2013-04-01 16:37:40 UTC
It would be useful to associate gerrit changesets to tags / keywords and then be able to retrieve that information in MediaWiki pages.

See the concept of Nodes at
https://www.mediawiki.org/wiki/User:Qgil/Contributors#Nodes

and the "Patches" box in this sketch
https://www.mediawiki.org/wiki/File:Wikitech_node_concept.jpg

If you don't see this happening anytime soon then maybe an option would be to get the list of "Patches" based on Bugzilla keywords + "patch-in-gerrit"...
Comment 15 Kunal Mehta (Legoktm) 2014-01-24 18:45:07 UTC
*** Bug 60401 has been marked as a duplicate of this bug. ***
Comment 16 Derk-Jan Hartman 2014-01-24 20:25:35 UTC
OK, so i'm thinking that you could have tags, dashboards on tags, and 'watch' tags so for instance:

Tag a review with: "db"
Have a dashboard showing all patch sets that require "db" review.
Authors could subscribe to tags and they would show up in a section of their personal dashboard: So a developer with experience in databases can subscribe to review queue that is tagged with db.

This would help because much of the review is knowledge domain specific and much less repository specific which is the current focus of gerrit.
Comment 17 Quim Gil 2014-08-13 13:07:59 UTC
Is it safe to assume that no further development will be put into our Gerrit instance? This request seems to be fulfilled by Phabricator + Differential features. See http://fab.wmflabs.org/tag/code_review_in_phabricator/
Comment 18 Chad H. 2014-08-13 18:52:30 UTC
(In reply to Quim Gil from comment #17)
> Is it safe to assume that no further development will be put into our Gerrit
> instance? This request seems to be fulfilled by Phabricator + Differential
> features. See http://fab.wmflabs.org/tag/code_review_in_phabricator/

Short of doing things to keep Gerrit from falling over/catching on fire, yes, that is a safe assumption. The majority of Gerrit bugs can probably be WONTFIXed on those grounds.
Comment 19 Nemo 2014-09-15 07:58:50 UTC
!!! https://code.google.com/p/gerrit/issues/detail?id=287 is marked fixed !!!

Upgrade upgrade upgrade upgrade upgrade upgrade upgrade
Comment 20 Nemo 2014-09-15 08:01:18 UTC
(Or maybe it's a misunderstanding?)
Comment 21 Seb35 2014-09-15 17:19:19 UTC
I’m not sure if I understood correctly the bug report, but it’s already possible to change the topic after the commit. See https://gerrit.wikimedia.org/r/#/c/160022/ for an example (a comment is added when topic changes). (I remarked this some days ago.)
Comment 23 Nemo 2014-09-15 17:37:34 UTC
(In reply to Seb35 from comment #21)
> I’m not sure if I understood correctly the bug report, 

And I'm not sure https://code.google.com/p/gerrit/issues/detail?id=287#c16 did either, given the link https://gerrit-review.googlesource.com/#/q/topic:hashtags

> but it’s already
> possible to change the topic after the commit. See
> https://gerrit.wikimedia.org/r/#/c/160022/ for an example (a comment is
> added when topic changes).

What we need is being able to tag a changeset after the *merge*. I don't see such an option for the topic anywhere (my changes, others' changes, new or old screen).

> (I remarked this some days ago.)

Where?
Comment 24 Seb35 2014-09-16 10:19:42 UTC
(In reply to Nemo from comment #23)
> (In reply to Seb35 from comment #21)
> > but it’s already
> > possible to change the topic after the commit. See
> > https://gerrit.wikimedia.org/r/#/c/160022/ for an example (a comment is
> > added when topic changes).
> 
> What we need is being able to tag a changeset after the *merge*. I don't see
> such an option for the topic anywhere (my changes, others' changes, new or
> old screen).
> 
> > (I remarked this some days ago.)
> 
> Where?

Ok, this is only before the merge (I didn’t catch this detail), small 'notepad' icon in the 'Topic' field.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links