Last modified: 2014-08-15 12:02:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37288, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35288 - the message articlefeedbackv5-disable-flyover-help-location is poorly placed and not needed anyway
the message articlefeedbackv5-disable-flyover-help-location is poorly placed ...
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Matthias Mullie
: i18n
Depends on:
Blocks: messages
  Show dependency treegraph
 
Reported: 2012-03-17 21:30 UTC by Amir E. Aharoni
Modified: 2014-08-15 12:02 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2012-03-17 21:30:38 UTC
There are two problems with the message articlefeedbackv5-disable-flyover-help-location:

1. As it is currently, it consists of two messages which are available in the core already: "My preferences" is 'mypreferences' and "Appearance" is 'prefs-rendering'. It can therefore be removed, and the existing messages can be used instead.

2. Along with 'Articlefeedbackv5-disable-flyover-help-goto', this is a "lego message" - they are combined together in code. This may be a problem for languages with different word order, for example, languages in which "to" comes after the location. It can also pose other problems. It should be considered to  combine this message as a parameter in 'Articlefeedbackv5-disable-flyover-help-goto', as it is already done with 'articlefeedbackv5-disable-flyover-help-emphasis-text'.
Comment 1 Amir E. Aharoni 2012-03-17 21:32:13 UTC
... And it looks like 'Articlefeedbackv5-disable-flyover-help-direction' is lego, too.
Comment 2 Reha Sterbin 2012-04-18 16:13:39 UTC
Lego message has been rewritten.  Issue with core messages still present.
Comment 3 Gerrit Notification Bot 2013-05-08 12:54:27 UTC
Related URL: https://gerrit.wikimedia.org/r/62808 (Gerrit Change I195eb8e19818ad4564da0d8c3216a1544c6f8138)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links