Last modified: 2005-09-19 22:48:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5513, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3513 - Max page length should be a system message
Max page length should be a system message
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikisource.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-19 22:41 UTC by Christian Neubauer
Modified: 2005-09-19 22:48 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Neubauer 2005-09-19 22:41:54 UTC
There is a hardcoded max page length in EditPage.php (for 1.5rc4 its on line
550).  If the page size is larger than this value MediaWiki:Longpagewarning is
displayed at the top of the Edit Page.  This maximum length should be a system
message so it can be customized by various wikis.  Wikis that require longer
page lengths (like wikisource) could then raise that value.

The code currently looks like:
$kblength = (int)(strlen( $this->textbox1 ) / 1024);
  if( $kblength > 29 ) {
    $wgOut->addWikiText( wfMsg( 'longpagewarning', $wgLang->formatNum( $kblength
) ) );
  }

and should be something like:
$kblength = (int)(strlen( $this->textbox1 ) / 1024);
  if( $kblength > wfMsg('longpagemaxvalue') ) {
    $wgOut->addWikiText( wfMsg( 'longpagewarning', $wgLang->formatNum( $kblength
) ) );
  }


Probably have to convert wfMsg('longpagemaxvalue') to an int.
Comment 1 Brion Vibber 2005-09-19 22:43:43 UTC
The warning size is directly based on known browser bugs, so would not be a 
customizable thing.
Comment 2 Christian Neubauer 2005-09-19 22:48:14 UTC
Bugs for old browsers.  The value is ignored on Wikisource anyway since it
doesn't make sense to break a novel up arbitrarily.  We get an annoying message
for no good reason.  See relavent discussion at
http://en.wikisource.org/wiki/Wikisource:Scriptorium#Page_lengths.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links