Last modified: 2014-09-23 22:34:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36999, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34999 - <ref> doesn't expand triple-brace template parameters
<ref> doesn't expand triple-brace template parameters
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-06 03:30 UTC by Bawolff (Brian Wolff)
Modified: 2014-09-23 22:34 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2012-03-06 03:30:17 UTC 
Originally reported here: https://www.mediawiki.org/w/index.php?title=Project:Support_desk&offset=20120306025209#using_urls_in_cite.php_12728

Given something like <ref>{{{foo}}}</ref>, the {{{foo}}} should be expanded with the content of the foo template parameter if applicable.

Basically all that needs to be done is add the PPFrame given as an argument to the <ref> callback as the second argument to the recursiveTagParse calls.
Comment 1 MZMcBride 2012-03-06 03:43:56 UTC 
Possibly related: bug 31374 comment 23.

I also imagine this bug is a dupe, but perhaps not.
Comment 2 Bawolff (Brian Wolff) 2012-03-06 14:53:24 UTC 
(In reply to comment #1)
> Possibly related: bug 31374 comment 23.

Yes, you can use #tag as a work around.

> I also imagine this bug is a dupe, but perhaps not.

I searched, but couldn't find one.
Comment 3 Krinkle 2012-03-07 07:36:31 UTC 
Duplicate of bug 24160, which is a duplicate of bug 2700.

*** This bug has been marked as a duplicate of bug 2700 ***
Comment 4 Bawolff (Brian Wolff) 2012-03-07 14:43:51 UTC 
(In reply to comment #3)
> Duplicate of bug 24160, which is a duplicate of bug 2700.
> 
> *** This bug has been marked as a duplicate of bug 2700 ***

triple brace expansion isn't done during PST. Re-opening.
Comment 5 Bawolff (Brian Wolff) 2012-07-08 17:57:57 UTC 
Gerrit change #14682.

However, I've never seen anyone else use replaceVariables in the way i did in that change, so we'll see if it passes review or not...
Comment 6 Sumana Harihareswara 2012-12-09 17:39:08 UTC 
The Gerrit patch was abandoned in August so this is free for the taking. :-)
Comment 7 Platonides 2012-12-09 17:41:58 UTC 
It would be easier to just use  {{#tag:ref| {{{foo}}} }} ...
Comment 8 Aalekh Nigam 2014-01-01 06:48:01 UTC 
Hi i am new to mediawiki can this bug be assigned to me i am really passionate about contributing to mediawiki....Thanks
Comment 9 Gerrit Notification Bot 2014-01-01 08:49:44 UTC 
Change 104794 had a related patch set uploaded by AalekhN:
Made Changes as per Bug 34999 <ref>{{{foo}}}</ref> is working on the local machine

https://gerrit.wikimedia.org/r/104794
Comment 10 Aalekh Nigam 2014-01-01 08:55:23 UTC 
Added a Patch Kindly review it......
https://gerrit.wikimedia.org/r/#/c/104794/
Comment 11 Andre Klapper 2014-02-18 21:05:01 UTC 
Hi Aalekh, the patch needs some rework, see the comments in Gerrit - would you be willing to work on it?
Comment 12 Aalekh Nigam 2014-02-18 22:34:41 UTC 
Yes sir I will try my best to solve the bug as soon as possible
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links