Last modified: 2010-05-15 15:37:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5485, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3485 - Uploading lowercase titles with $wgCapitalLinks=false still triggers warning
Uploading lowercase titles with $wgCapitalLinks=false still triggers warning
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-16 22:21 UTC by Dave Miller (ProgMania)
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dave Miller (ProgMania) 2005-09-16 22:21:38 UTC
e.g. Upload file "helloWorld.txt" and it says it's going to be renamed to "helloWorld.txt" (the 
same title).

PATCH for includes/SpecialUpload.php:

FIND:
if( $this->mUploadSaveName != ucfirst( $filtered ) ) {
  $warning .=  '<li>'.wfMsg( 'badfilename', htmlspecialchars( $this->mUploadSaveName ) ).'</li>';
}

REPLACE WITH:
if ( $wgCapitalLinks ) {
  $filtered = ucfirst( $filtered );
}
if( $this->mUploadSaveName != $filtered ) {
  $warning .=  '<li>'.wfMsg( 'badfilename', htmlspecialchars( $this->mUploadSaveName ) ).'</li>';
}

(or put the first bit further up, where $filtered is first defined.)
Comment 1 Brion Vibber 2005-09-17 00:22:15 UTC
Applied to REL1_5 and HEAD.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links