Last modified: 2012-05-03 02:45:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36775, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34775 - [Regression] Special:NewPages should show correct page status
[Regression] Special:NewPages should show correct page status
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: MW 1.19 version
Assigned To: Nobody - You can work on this!
https://pl.wikipedia.org/wiki/Specjal...
: code-update-regression
Depends on:
Blocks: 31217
  Show dependency treegraph
 
Reported: 2012-02-28 18:32 UTC by Beau
Modified: 2012-05-03 02:45 UTC (History)
5 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (218.53 KB, image/png)
2012-02-28 19:51 UTC, Beau
Details

Description Beau 2012-02-28 18:32:15 UTC
On pl.wikipedia many editors use Special:NewPages to review new pages. After update to MW 1.19 the special page no longer marks unreviewed new pages. It either shows all as not patrolled to sysops, or as reviewed to normal users.
Comment 1 Aaron Schulz 2012-02-28 18:33:50 UTC
Does https://pl.wikipedia.org/w/index.php?title=Specjalna:Nowe_strony&hideReviewed=1 still hide reviewed pages?
Comment 2 Beau 2012-02-28 18:43:06 UTC
Yes, but the unreviewed pages are no longer marked by background color. 

Also changing filter (for example: namespace) and clicking go, and then clicking on "Hide reviewed edits" removes the filter.
Comment 3 Leinad 2012-02-28 18:43:54 UTC
To clarify - Polish Wikipedia has FlaggedRevs extensions and the problem are pages marked as 'sighted' which are still on yellow backgound.
Comment 4 Aaron Schulz 2012-02-28 19:28:07 UTC
(In reply to comment #3)
> To clarify - Polish Wikipedia has FlaggedRevs extensions and the problem are
> pages marked as 'sighted' which are still on yellow backgound.

I tested this on my test wiki and I don't have the problem where pages still show up in yellow even after page review.

I tested plwiki as an 'editor' and a regular user and there was no yellow at all. As a 'sysop', the yellow backgrounds display as expected (yellow <=> reviewed).
Comment 5 Beau 2012-02-28 19:38:25 UTC
The problem is that unreviewed pages are not marked for 'editors'. To sysop they are all shown as yellow, because sysops have '''patrol''' right and Special:NewPages shows that status. We do not use patrol feature built in MediaWiki on pl.wikipedia. Before upgrade it worked just fine and the page shown review status (from FlaggedRevs, not from patrol feature).
Comment 6 Aaron Schulz 2012-02-28 19:39:54 UTC
It sounds like 'editors' on plwiki should have the 'patrolmarks' right then.
Comment 7 Beau 2012-02-28 19:46:27 UTC
The issue is that sysops see pages marked as yellow which have either reviewed or unreviewed status (from FlaggedRevs extension perspective). That yellow marking is taken from patrol mechanism, not FlaggedRevs which is the issue here.
Comment 8 Beau 2012-02-28 19:51:35 UTC
Created attachment 10125 [details]
Screenshot

I have attached a sample screenshot. It contains pages:
* "Yoo Byung-ok" - page was reviewed, marked as yellow
* "Joanna Sarapata" - page does not have any reviewed versions, marked as yellow
* "Odznaka za zasługi w pracy penitencjarnej" - page was revied, not marked
Comment 9 Aaron Schulz 2012-02-28 19:55:35 UTC
(In reply to comment #7)
> The issue is that sysops see pages marked as yellow which have either reviewed
> or unreviewed status (from FlaggedRevs extension perspective). That yellow
> marking is taken from patrol mechanism, not FlaggedRevs which is the issue
> here.

This is a completely different matter than comment #5. Two different things are being described here:
1) Who can yellow marks on NewPages
2) Whether those yellow marks are correct or not
Comment 10 Aaron Schulz 2012-02-28 22:55:02 UTC
2) should be fixed in r112653.
Comment 11 Aaron Schulz 2012-02-29 17:37:09 UTC
1) Done just now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links