Last modified: 2012-05-03 02:42:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36734, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34734 - compressOld.php ignoring -s option
compressOld.php ignoring -s option
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.19
All All
: Low normal (vote)
: 1.19.0 release
Assigned To: Antoine "hashar" Musso (WMF)
: patch, patch-reviewed
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2012-02-26 16:05 UTC by christian
Modified: 2012-05-03 02:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch fixing the treatment of the -s option (622 bytes, patch)
2012-02-26 16:05 UTC, christian 		Details
Add an attachment (proposed patch, testcase, etc.)

Description christian 2012-02-26 16:05:00 UTC 
Created attachment 10104 [details]
Patch fixing the treatment of the -s option

According to it's documentation, compressOld.php allows to limit the treated ids using the "-s" option.
However, the "-s" option is ignored.php.
The attached patch fixes the problem.




Actual Behavior:
----------------
> compressOld.php -t gzip -s 6

Compressing database wikisvn
----------------------------------------------------------------------------

Starting from old_id 0...




Expected Behavior:
------------------
> compressOld.php -t gzip -s 6

Compressing database wikisvn
----------------------------------------------------------------------------

Starting from old_id 6...
Comment 1 Antoine "hashar" Musso (WMF) 2012-03-01 11:31:54 UTC 
This is a regression caused by r90549 and hence in 1.19.
Comment 2 Antoine "hashar" Musso (WMF) 2012-03-01 11:37:58 UTC 
Fix applied:
In trunk with r112793
In 1.19wmf1 with r112794
In REL1_19 with r112795

Thanks for the patch!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links