Last modified: 2014-02-12 23:53:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36686, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34686 - Left alligned images should come alongside text
Left alligned images should come alongside text
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
http://ta.m.wikipedia.org
: patch, patch-need-review
Depends on:
Blocks: 32578
  Show dependency treegraph
 
Reported: 2012-02-24 11:40 UTC by Srikanth Logic
Modified: 2014-02-12 23:53 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to fix (286 bytes, patch)
2012-02-25 16:49 UTC, Srikanth Logic
Details

Description Srikanth Logic 2012-02-24 11:40:23 UTC
I was trying make the image come along side text for Tamil mobile page, was able to get it fixed with this change
http://ta.wikipedia.org/w/index.php?diff=1035058&oldid=1034263

I dont think this is ideal fix, since one cant add an extra div tag alongside wikitext just for mobilefrontend. So this might be an issue with mf. Correct me if am wrong.

[[Image:xyz.jpg|100px|left]] puts the image inside <div class="floatleft">, but the image doesnt come alongside the text and text goes down.

[[Image:xyz.jpg|100px|right]] puts the image inside <div class="floatright">,  the image does come alongside the text.

So floatleft needed an extra style attribute for the image to come properly. I guess the style is missing in the class or something?

Feel free to undo/redo the below edit with a edit summary to reproduce the issue

http://ta.wikipedia.org/w/index.php?diff=1035058&oldid=1034263

I also noticed similar issue in http://ml.m.wikipedia.org.

I took the fix from de.m.wikipedia.org where they seem to add the styling as part of a template and the same goes for both mobile / desktop versions.
Comment 1 Srikanth Logic 2012-02-25 16:49:47 UTC
Created attachment 10098 [details]
Patch to fix

Patched /extensions/MobileFrontend/stylesheets/common.css and it worked fine locally! Not a great deal, but first patch submitted :)
Comment 2 Sumana Harihareswara 2012-02-26 03:59:23 UTC
Patch awaits review; added keyword.  Thanks, Srikanth.
Comment 3 Jon 2012-02-28 18:20:37 UTC
I've applied the patch in r112622
Thanks so much for your contribution!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links