Last modified: 2012-05-03 02:42:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36510, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34510 - monobook toolbar or vector with old toolbar not setup randomly
monobook toolbar or vector with old toolbar not setup randomly
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
All All
: High major (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-02-19 11:11 UTC by Philippe Elie
Modified: 2012-05-03 02:42 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Philippe Elie 2012-02-19 11:11:30 UTC
with the old toolbar button are inserted through a fragment of javascript looking like

mw.loader.using("mediawiki.action.edit", function() {mw.toolbar.addButton(...
$(function() { mw.toolbar.init(); } );

init fail in some case because the selector in /resources/mediawiki.action/mediawiki.action.edit.js : $toolbar : $( '#toolbar' ), doesn't return the toolbar div element, when failure occur document.readyState == false, ditto for $.isReady, look like mw.toolbar can be init before the DOM is fully built.

This is not easy to reproduce, for some user it fails always, for other never and so on.
Comment 1 Philippe Elie 2012-02-19 14:52:31 UTC
sorry, in comment 1 I mean document.readyState == "loading" and $.isReady == false
Comment 2 Rob Lanphier 2012-02-19 18:44:03 UTC
Philippe, did you notice this problem prior to early Saturday morning (late Friday in the U.S.)  We deployed a fix for bug 34431 that might be related to this problem.  See r111796 for the change
Comment 3 Philippe Elie 2012-02-19 19:33:44 UTC
I don't see the patch you're talking about in 1.19wmf1, only in trunk.

Multiple problem occurred making some button randomly appearing/disappearing since 1.19 deployment (#34409 has some impact on some button on I *think* italic/bold button disappear at very start of deployment.

I don't see a possible relationship between jquery selector called in mediawiki.action.edit.js while the DOM is not already built and the wikieditor. Isn't the problem than more code in mediawiki.action.edit.js should be protected by a $( document ).ready( function() ?
Comment 4 Antoine "hashar" Musso (WMF) 2012-02-20 15:00:09 UTC
tagged r111796 for 1.19wmf1 merge
Comment 5 Chris McMahon 2012-02-21 19:29:53 UTC
bug 34431 fix seems to have fixed this as well.

Note You need to log in before you can comment on or make changes to this bug.