Last modified: 2012-10-03 09:42:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 34495 - Patrol log should refer to the user performing the action instead of the user who made the patrolled edit
Patrol log should refer to the user performing the action instead of the user...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.19
All All
: High normal (vote)
: 1.20.0 release
Assigned To: Niklas Laxström
:
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2012-02-18 17:02 UTC by Philippe Elie
Modified: 2012-10-03 09:42 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Philippe Elie 2012-02-18 17:02:50 UTC 
on IRC RC #fr.wikisource I saw:

<rc-pmtpa> [[Spécial:Log/patrol]] patrol  * Jujens *  Jujens a marqué la révision 3264632 de la page [[Page:Féval - Le Bossu (1857) vol 1-3.djvu/98]] comme contrôlée

(* Jujens *  Jujens has marked rev 3264632 ... as patrolled)

but Jujens has no patrol right.

The log show the patrol was done by user Aristoi on a Jujens contribution so it's only the comment send to the channel which is wrong http://fr.wikisource.org/w/index.php?title=Sp%C3%A9cial%3AJournal&type=patrol&user=Aristoi

I never noticed that before the switch to 1.19, no idea if it's related.
Comment 1 Philippe Elie 2012-02-18 17:18:21 UTC 
more info, the patrol log is corrupted too, all patrolling seems credited to editor patrolled, not to the editor patrolling
Comment 2 Nemo 2012-02-20 21:05:56 UTC 
(In reply to comment #0)
> it's only the comment send to the channel which is wrong

Then marking as duplicate of bug 34508, whose fix is going to require rewrite of the whole thing anyway (apparently).

*** This bug has been marked as a duplicate of bug 34508 ***
Comment 3 Mark A. Hershberger 2012-02-20 21:13:35 UTC 
Reopening per IRC:

  <Nikerabbit> hexmode: it should be simple one line fix
  <Nikerabbit> hexmode: in PatrolLog.php, replace "$entry->setPerformer(
             User::newFromName( $rc->getAttribute( 'rc_user_text' ) ) );" with
             $wgUser
Comment 4 Mark A. Hershberger 2012-02-20 21:54:27 UTC 
r111965
Comment 5 Antoine "hashar" Musso (WMF) 2012-02-20 22:13:21 UTC 
Typo fixed with r111967

Both merged to 1.19wmf1 with r111969

I have deployed the change on testwiki and then enabled $wgRCPatrol. Upon patrolling of a random edit, the bot output was:

<rc-pmtpa>
[[Special:Log/patrol]] patrol * Hashar *  Hashar marked revision 125809 of page [[Talk:Main Page]] patrolled
Comment 6 Antoine "hashar" Musso (WMF) 2012-02-20 22:14:46 UTC 
Applied live for all wiki. Thanks for the bug report :-)
Comment 7 Steve 2012-08-11 14:05:18 UTC 
This is still an issue in 1.19.1.
Comment 8 Robert Morley 2012-09-04 04:51:11 UTC 
The suggested fix doesn't appear in 1.19.2 either. This appears to never have been deployed to the release version.
Comment 9 Robin Pepermans (SPQRobin) 2012-09-04 12:50:53 UTC 
(In reply to comment #8)
> The suggested fix doesn't appear in 1.19.2 either. This appears to never have
> been deployed to the release version.

It was merged to 1.19wmf1 in r111969 but indeed never to the 1.19 release.
Comment 10 Mark A. Hershberger 2012-10-01 17:31:50 UTC 
updating milestones
Comment 11 Antoine "hashar" Musso (WMF) 2012-10-02 08:43:24 UTC 
Although this bug fix missed the 1.19 releases, it is already in 1.20. I have added a release notes entry for 1.20 with Gerrit change #26004 (master) and Gerrit change #26006 (REL1_20).

I guess that will solve this bug.
Comment 12 Antoine "hashar" Musso (WMF) 2012-10-03 09:42:28 UTC 
Both changes have been merged. The bug fix will be in MediaWiki 1.20 releases.

Sorry for the trouble :/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links