Last modified: 2014-08-29 08:26:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36423, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34423 - Edit conflicts with yourself are not detected when doing no section edit - inconsistent behavior
Edit conflicts with yourself are not detected when doing no section edit - in...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.19
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: section-editing 70163
  Show dependency treegraph
 
Reported: 2012-02-15 19:27 UTC by Saibo
Modified: 2014-08-29 08:26 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Saibo 2012-02-15 19:27:48 UTC
That is in 1.18 production wiki.

Edits made in two tabs with opening https://de.wikipedia.org/w/index.php?title=Datei:Logo_African_Pygmy_Goat.png&action=edit in both

* first edit: https://de.wikipedia.org/w/index.php?title=Datei:Logo_African_Pygmy_Goat.png&diff=99713605&oldid=99710289
* second edit: https://de.wikipedia.org/w/index.php?title=Datei:Logo_African_Pygmy_Goat.png&diff=99713610&oldid=99713605


Second edit overwrote the first edit - there must be displayed an edit conflict but it was not. 

Correct and expected behavior can be observed here:
Same but edits made with https://de.wikipedia.org/w/index.php?title=Datei:Logo_African_Pygmy_Goat.png&action=edit&section=2 (note the section param!)
*first edit: https://de.wikipedia.org/w/index.php?title=Datei:Logo_African_Pygmy_Goat.png&diff=99714085&oldid=99713610
*second edit: Result on saving the second edit: edit conflict (I had added "barfoo" at the same place where I had added "foobar" (first edit).


Another example where there was no EC displayed: https://de.wikipedia.org/w/index.php?title=Datei_Diskussion:Logo_African_Pygmy_Goat.png&diff=99711750&oldid=99711748

Also no EC displayed in MW 1.19 testwiki: https://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=35606&oldid=35605  
and:  https://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=35626&oldid=35625  
Similarly  no EC is shown in MW 1.19 (resulting in "overwriting" the older edit) if: a) both edits are made by the same user, b) the second edit is done via "edit" at top and not using sections. 

To repeat: 
* If the second edit is done with a section parameter: a EC is (correctly) detected...
* If the users making the edits are different user accounts: a EC is (correctly) detected...
Comment 1 Quedel 2012-02-15 19:45:00 UTC
Thanks to user:Saibo, without him, i never could make such a well bugzilla-report.
Comment 2 Saibo 2012-02-16 01:46:09 UTC
(In reply to comment #1)
> Thanks to user:Saibo, without him, i never could make such a well
> bugzilla-report.

:-)  That said, Quedel discovered that bug and tested together with me. :-)  Okay enough honoring now! ;-)
Comment 3 Mark A. Hershberger 2012-02-16 20:03:23 UTC
Does this happen only when using the same browser?  What if you are using two different browsers and two different users?
Comment 4 Mark A. Hershberger 2012-02-16 20:10:12 UTC
Doh, missed this bit:

> * If the users making the edits are different user accounts: a EC is
> (correctly) detected...

prioritizing accordingly.
Comment 5 Quedel 2012-02-16 20:39:55 UTC
So, I tested it: using Firefox 10.0.1 and IE8. I have try a test-run. While 1, 2, 3 ... is the number of run, a is the first saved, b the second. Here I only give the second-edit link, so deletions of first edit can be easily seen.

# https://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=36069 : both on FF, both logged in, edited in two tabs: the second edit is deleting the first one.

# https://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=36071 : first on FF logged-in, second on IE logged-off. Both edits are combined.

# https://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=36073 : first on IE logged-off, second on FF logged-in. Both edits are combined.

# https://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=36075 : first edit on IE logged-in, second on FF logged-in, the second edit is deleting the first one.

# http://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=36077 : first edit on FF logged-off, second on IE logged-off, a edit-conflict was shown.

# http://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=35627 : first edit User:Quedel, second edit User:Saibo on the same row. Second edit deletes the first one.

So it seems that it can be reproduced for logged-in-users only. If one or two browsers are used; if one or two users are doing this - everytime the second edit is deleting the first (if full-article-editing, not section-param-editing).
Comment 6 Quedel 2012-02-16 20:47:32 UTC
I have to correct
> #
> http://test2.wikipedia.org/w/index.php?title=File:AaatestSonnepalmenstrand-portrait_new.jpg&diff=next&oldid=35627
> : first edit User:Quedel, second edit User:Saibo on the same row. Second edit
> deletes the first one.
> 
> So it seems that it can be reproduced for logged-in-users only. If one or two
> browsers are used; if one or two users are doing this - everytime the second
> edit is deleting the first (if full-article-editing, not
> section-param-editing).

We tested it again 
# http://test2.wikipedia.org/w/index.php?title=File%3AAaatestSonnepalmenstrand-portrait_new.jpg&revisiondelete=Gew%C3%A4hlte+Versionen+zeigen%2Fverstecken&diff=36080&oldid=36079&revisiondelete=Gew%C3%A4hlte+Versionen+zeigen%2Fverstecken
 If the users make the edits, both edits were combined in this case.

To say, that all tests (including on Comment 5) were made on two different lines, not editing the same line / words.
Comment 7 Quedel 2012-02-16 20:49:12 UTC
If two logged-in users made changes on the same word, a edit-conflict is shown.
Comment 8 db [inactive,noenotif] 2012-02-18 17:43:41 UTC
EditPage.php has some checks for edit conflicts. The comment at that place is:

Suppress edit conflict with self, except for section edits where merging is required.
Comment 9 Nemo 2013-03-06 08:11:22 UTC
(In reply to comment #8)
> EditPage.php has some checks for edit conflicts. The comment at that place
> is:
> 
> Suppress edit conflict with self, except for section edits where merging is
> required.

Bug 28720 requests to remove that behaviour and has more background.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links