Last modified: 2012-05-03 02:42:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 33660 - [Regression] window.ProtectionForm is not defined
[Regression] window.ProtectionForm is not defined
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
All All
: Highest blocker (vote)
: 1.19.0 release
Assigned To: Krinkle
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-01-11 14:50 UTC by Niklas Laxström
Modified: 2012-05-03 02:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Niklas Laxström 2012-01-11 14:50:39 UTC
Happens on ?action=protect on
Comment 1 Krinkle 2012-01-22 02:44:58 UTC
Caused by a race condition. Inline code does not properly wait the module:

<select id="mwProtectExpirySelection-edit" name="wpProtectExpirySelection-edit" onchange="ProtectionForm.updateExpiryList(this)" 
<!-- /footer -->
mw.loader.load([..., "mediawiki.legacy.protect", ..]);
ProtectionForm.init({"tableId": "mwProtectSet", "labelText": "Unlock further protect options", "numTypes": 2, "existingMatch": true});

Both the inline onchange handler and the init() call on the bottom are called before the module is loaded. 

On the long term bug 33871 is the right solution. On the short solution we should add this module to the top-queue instead of the bottom queue, so that it is available throughout the page.
Comment 2 Krinkle 2012-01-22 02:51:22 UTC
Fixed in r109718.

Note You need to log in before you can comment on or make changes to this bug.