Last modified: 2012-08-14 11:37:15 UTC
Created attachment 9704 [details] Patch for mediawiki.action.history.diff.css Patch to swicth the new diff colors around: left side blue, right side green. Also restore #eee background for context lines. As discussed on r105280.
Created attachment 9709 [details] Patch for mediawiki.action.history.diff.css Remove outline for .diffchange and redundant CSS.
Will review this patch. There is some discussion on r105280, we probably want to reach a consensus before applying the patch though.
Hold on for a bit... I have another patch up for review.
Created attachment 9723 [details] Patch for mediawiki.action.history.diff.css Further tweaks: whole cell is now pre-wrap, removed dotted outline.
Assigning to Brandon now. He has a color change he plans to try out here.
Can brandon spill some beans so we can try them out first?
I took a stab at this within r106884, going with Yellow and Blue. I actually had a really nice looking version with violet and blue that was awesome. . . until you flipped on the colorblindness filters, and the two sides looked *exactly the same*.
After testing this code, I can only say: please revert! Not only is this a completely unilateral change that goes completely agains what has been discussed in r105280, it looks horrible to boot. The yellow and blue levels are totally incompatible; the bright yellow completely overpowers the dull blue. No one asked for the font size change and pre-wrap is not applied. The yellow/blue is a good premise, but these colors are just thrown together from the old and the new.
Created attachment 9753 [details] Patch for mediawiki.action.history.diff.css Changed blue/green to yellow/blue. In response to r106884.
Created attachment 9754 [details] Patch for mediawiki.action.history.diff.css Changed the blue highlight.
Created attachment 9755 [details] Patch for mediawiki.action.history.diff.css Adjust .diff-deletedline .diffchange background.
Green was dropped entirely with r106884. The diff colors are now yellow/blue. Those provide a sane default to MediaWiki installation and any project can override them locally if needed. Please note the pre-wrap is applied by the 'diffchange' class. If it needs to be moved somewhere else, can you please open a new bug with a new patches? Thanks! :-) Marking this bug which is about color swapping, as resolved.
Please do not unilaterally close bugs that are not resloved. Barndon's patch clearly has issues as outlined in r106884. And why should I file different patches while issues can be fixed in one go?
Changed (and fixed) title to reflect current issues.
(In reply to comment #13) > Please do not unilaterally close bugs that are not resolved. The bug title was originally about swapping the diff colors, specially not having green on the left side. Since green was removed the original issue is resolved. >Barndon's patch clearly has issues as outlined in r106884. The issues are not clear at all. The colors you are proposing are really minor changes and I do not understand how they are better than the one currently in use. I don't understand why you are moving the pre-wrap around. What is the purpose of this change? > And why should I file different patches while issues can be fixed in one go? Cause we do not want to have one bug with several issues and ton of patches. It is way easier to have one bug per issue.
I *can't* have different bugs open for this, because it would result in clashing patch files; this bug encompasses diff view as a whole. And please read the whole discussion regarding Barndon's patch; I am not the only one that hates the hellish yellow. We *had* consensus when Barndon came in and completely waltzed over it. That patch is not going to make in into MediaWiki if I can help it.
My name is spelled "Brandon" actually, not "Barndon". Local wikis will be able to make their own overrides. I was asked to apply design sense to the diff colors; I did. The code was checked in, it was reviewed, it was marked okay. I'm closing this bug (again) because the only thing that is happening now is bikeshedding.
Fine. I'l just submit a new bug. I was only trying to centralize discussion, but that is obviously impossible here.
*** This bug has been marked as a duplicate of bug 33335 ***
*** This bug has been marked as a duplicate of bug 11374 ***
