Last modified: 2013-07-11 22:39:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35123, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33123 - Enable $wgShowUpdatedMarker on the English Wikipedia
Enable $wgShowUpdatedMarker on the English Wikipedia
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on: 28026
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-14 18:52 UTC by Erwin Dokter
Modified: 2013-07-11 22:39 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erwin Dokter 2011-12-14 18:52:49 UTC
Per RFC held on [[Wikipedia:Village pump (proposals)#Enable "Show changes since last visit" on watchlist]], I would like to request that the $wgShowUpdatedMarker option be set to "true" for the English Wikipedia.
Comment 1 Sam Reed (reedy) 2011-12-19 21:36:53 UTC
This sounds familiar (ENotif?), and I'm not sure it's so straight forward...
Comment 2 Happy-melon 2011-12-19 21:53:45 UTC
(In reply to comment #1)
> This sounds familiar (ENotif?), and I'm not sure it's so straight forward...

IIRC the main issues are a) caching, and b) not being attacked by an angry Domas for causing a db write on every pageview...
Comment 3 Erwin Dokter 2011-12-19 23:48:21 UTC
If there are concerns about performance, back them up with data please. There are plenty of projects running on the same cluster with the option enabled, so I really see no reason to exclude the English Wikipedia.
Comment 4 p858snake 2011-12-19 23:51:23 UTC
(In reply to comment #3)
> If there are concerns about performance, back them up with data please. There
> are plenty of projects running on the same cluster with the option enabled, so
> I really see no reason to exclude the English Wikipedia.

Most (if any) of those are the same as DB wise as en.wikipedia
Comment 5 p858snake 2011-12-19 23:53:09 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > If there are concerns about performance, back them up with data please. There
> > are plenty of projects running on the same cluster with the option enabled, so
> > I really see no reason to exclude the English Wikipedia.
> 
> Most (if any) of those are the same as DB wise as en.wikipedia

* Most (if any) of those are the same size DB wise as en.wikipedia
Comment 6 Happy-melon 2011-12-20 01:02:43 UTC
(In reply to comment #5)
> Most (if any) of those are the same size DB wise as en.wikipedia

*Few* (if any)...??

(In reply to comment #3)
> If there are concerns about performance, back them up with data please. There
> are plenty of projects running on the same cluster with the option enabled, so
> I really see no reason to exclude the English Wikipedia.

I'm not in any place to say whether there *are* crippling performance concerns; only that that is, IIRC, a concern that has been raised about this feature in the past.  

$wgShowUpdatedMarker is enabled on WMF wikis which have $wgEnotifWatchlist enabled (or rather, is disabled on wikis which don'w).  The vast majority of wikis which have it enabled are fishbowls; public wikis basically come down to:

	'arwikiversity' => true,
	'brwikimedia' => true,
	'commonswiki' => true,
	'cswiki' => true,
	'cswikinews' => true,
	'cswikiversity' => true,
	'enwikisource' => true,
	'frrwiki' => true,
	'hiwiki' => true,
	'nlwiki' => true,
	'mediawikiwiki' => true,
	'metawiki' => true,
	'nowikinews' => true,
	'ptwiki' => true,
	'sourceswiki' => true,

None of those are anywhere near the top of the traffic list (note that's fr*r*wiki, not frwiki).
Comment 7 Erwin Dokter 2011-12-20 02:27:27 UTC
> $wgShowUpdatedMarker is enabled on WMF wikis which have
> $wgEnotifWatchlistenabled...

I don't see how the two are related. $wgShowUpdatedMarker requires $wgEmailAuthentication to be set, but none of the $wgEnotifXXX options. We're not requesting email notification, we're requesting Watchlist notification.
Comment 8 Happy-melon 2011-12-20 10:55:34 UTC
(In reply to comment #7)
> > $wgShowUpdatedMarker is enabled on WMF wikis which have
> > $wgEnotifWatchlistenabled...
> 
> I don't see how the two are related. 

CommonSettings.php:
	// Enable enotif for user talk if it's on for watchlist.
	if ( $wgEnotifWatchlist ) {
	  $wgEnotifUserTalk = true;
	} else {
	  $wgShowUpdatedMarker = false; // not working right ?

	  // Trial by Roan, Mark B and Mark H, Nov 8 2011
	  // Set $wgEnotifUserTalk to true everywhere, but keep $wgShowUpdatedMarker disabled where it was disabled previously
	  $wgEnotifUserTalk = true;
	}

Again, I'm not saying that things *have* to be this way; I'm saying how they currently *are*.
Comment 9 Sam Reed (reedy) 2012-05-10 17:44:35 UTC
Actually done now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links