Last modified: 2014-02-12 23:54:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34302, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32302 - MobileFrontend fullscreen search list item borders round poorly on 240dpi Android devices
MobileFrontend fullscreen search list item borders round poorly on 240dpi And...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
http://nomad.tesla.usability.wikimedi...
: patch, patch-need-review
Depends on:
Blocks: hidpi
  Show dependency treegraph
 
Reported: 2011-11-09 00:08 UTC by Brion Vibber
Modified: 2014-02-12 23:54 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot on Nexus 1, Android 2.3.6, Android stock browser (35.58 KB, image/png)
2011-11-09 00:08 UTC, Brion Vibber
Details
Sample patch switching from <hr> to border-bottom for the dividers (1.14 KB, patch)
2011-11-19 00:47 UTC, Brion Vibber
Details
Screenshot comparing rendering of <hr> vs border-bottom on 120, 160, 240dpi Android emu (130.14 KB, image/png)
2011-11-19 00:49 UTC, Brion Vibber
Details

Description Brion Vibber 2011-11-09 00:08:33 UTC
Created attachment 9393 [details]
Screenshot on Nexus 1, Android 2.3.6, Android stock browser

The borders on the list items in the new search interface end up alternating between 1px and 2px of gray on Android hdpi (240dpi) devices due to rounding inconsistencies.

It just looks kinda icky!

CSS media queries may be able to detect that we're on 240dpi and adjust the styles to something that'll round consistently to 1px?
Comment 1 Brion Vibber 2011-11-09 00:40:12 UTC
Adding high-density tracking bug 32101.
Comment 2 Brion Vibber 2011-11-19 00:47:55 UTC
Created attachment 9493 [details]
Sample patch switching from <hr> to border-bottom for the dividers

Looks like the current code is putting <hr>s in between the <div>s as separators.

This is probably contributing to other problems like the highlight bar not reaching the entire row as well...

Per screenshot about to attach, Android 2.3 browser at least does a much better job making the borders appear consistent, while the <hr>s vacillate between too thin and too thick at 120 and 240 dpi (ldpi & hdpi).
Comment 3 Brion Vibber 2011-11-19 00:49:09 UTC
Created attachment 9494 [details]
Screenshot comparing rendering of <hr> vs border-bottom on 120, 160, 240dpi Android emu

borders are rendered much more consistently than <hr>s!
Comment 4 Brion Vibber 2011-11-19 00:53:02 UTC
(Note that increasing the padding can keep the previous spacing/look.)
Comment 5 Patrick Reilly 2011-11-30 19:31:52 UTC
Okay, this fix is now included in r104725.
Comment 6 Patrick Reilly 2011-11-30 19:35:04 UTC
Also, non full screen fix is in r104726.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links