Last modified: 2012-04-19 21:22:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33602, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31602 - Do not use native datalist support in mediawiki.legacy.mwsuggest
Do not use native datalist support in mediawiki.legacy.mwsuggest
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.18.0 release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31654 31768
  Show dependency treegraph
 
Reported: 2011-10-11 09:05 UTC by Michael M.
Modified: 2012-04-19 21:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (1.82 KB, patch)
2011-10-20 07:32 UTC, Michael M.
Details

Description Michael M. 2011-10-11 09:05:47 UTC
Since 1.18 mediawiki.legacy.mwsuggest uses the HTML5 datalists for search suggestions in Monobook skin in all browsers that implemented this feature except Opera, which is blacklisted because of some bug.
Please blacklist Firefox as well, the width of the box with the suggestions isn't increased, so the entries are truncated. See screenshot on de.wikipedia: http://de.wikipedia.org/wiki/Datei:Minisuchfeld_bei_MW118.jpg The screenshot is taken with Firefox 8, I could confirm this issue with Firefox 5, too.
Comment 1 Niklas Laxström 2011-10-11 09:09:13 UTC
Is this also the cause for having double dropdowns in Chrome?
Comment 2 Michael M. 2011-10-17 07:53:34 UTC
Datalists seem to have problems in all browsers:
* Opera already is blacklisted
* Firefox doesn't increase the width, search doesn't start after user selects a suggestion (bug 31654)
* Safari 5 doesn't show the suggestions at all (bug 31768)

Having two different implementations (native datalists vs. self-made list) is confusing when you try to help others figuring out where the problem is, and after the above list of browser bugs I can't believe that any other browser has an implementation that is usable in every situation so I suggest to set
window.os_use_datalist = false
again, i. e. revert revision 79363.
Comment 3 Michael M. 2011-10-20 07:32:23 UTC
Created attachment 9261 [details]
Proposed patch

While I tested the patch I found another problem with HTML5 datalists (tested in Firefox 4, but probably a problem in every implementation):
My testwiki uses German localization, so user pages begin with "Benutzer:" or "Benutzerin:" for females. When datalists are used only those pages were shown, which start with the exact namespace, i. e., typing "User:" didn't show any page, "Benutzer:" showed only pages of male or neutral users, "Benutzerin:" only pages of females. After I disabled datalists all three could be used to show any userpage as it should be.
Comment 4 Niklas Laxström 2011-10-20 10:20:06 UTC
Oh really? We have specific bug about that: bug 31697.
Comment 5 Mark A. Hershberger 2011-10-20 15:00:10 UTC
see r100348 for possible fix.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links