Last modified: 2010-05-15 15:37:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3125 - Special:Import sets unused attribute in form input
Special:Import sets unused attribute in form input
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2005-08-12 12:48 UTC by John Owens
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description John Owens 2005-08-12 12:48:25 UTC
I noticed that in the Special:Import page, the input for the file looks like this:

<input type='file' name='xmlimport' value='' size='30' />

but according to the HTML specs ( ), the size
attribute only applies to the text and password input types.
If there's some particular buggy browser out there that requires a size for a
file input, I suppose this should stay, since decent browsers will ignore it
anyway. But if it's not needed by any browser, it should go away.
It's in includes/SpecialImport.php, line 85 (as of 1.5beta4).
Comment 1 Antoine "hashar" Musso (WMF) 2005-08-13 07:44:23 UTC
Reread the spec. size attribute is valid for any type of <input> element.
Comment 2 John Owens 2005-08-13 12:43:04 UTC
So we really want a tiny 30 pixel wide filename input? I know on my Firefox
1.0.6 I get an input 110px wide anyway, and that's not enough really.
Comment 3 Ævar Arnfjörð Bjarmason 2005-08-13 12:45:07 UTC
(In reply to comment #2)
> So we really want a tiny 30 pixel wide filename input?

The report was that the size attribute was invalid and shouldn't be used, the
value of that attribute is another issue.
Comment 4 Antoine "hashar" Musso (WMF) 2005-08-13 13:06:09 UTC
Most probably the w3c spec forgot the that <input> with the 'file'
type also 'almost' use character size for the width.

Sample test:
1width:<input type='file' size='1' /><br>
2width:<input type='file' size='2' /><br>
30width:<input type='file' size='30' /><br>
31width:<input type='file' size='31' /><br>
800width:<input type='file' size='800' />

Render the same under linux firefox and win32 ie6.

Now if you find that the W3C is wrong or that browser does not render
stuff correctly send them a bug report.

Closing bug.

Note You need to log in before you can comment on or make changes to this bug.