Last modified: 2014-11-17 09:21:27 UTC
Created attachment 9115 [details] rev 0.1, untested. make it match SpecialListusers.php paging links (nav bars) for [[special:GlobalUsers]] send you to [[special:listusers]] (a different special page) This patch makes SpecialGlobalUsers.php match SpecialListusers.php This is untested, may not actually fix it.
I don't think this is the right approach. We should be setting the resource context from the first argument to the constructor. However, larger question - why doesn't this work currently (On 1.18 it should get the main resource context, which should point to the right place. On 1.17 it should use $wgTitle)
Marking testme. I think the issue might dissapear upon upgrade to 1.18... (I kind of wish centralAuth wasn't such a pain to set up locally for testing)
I'm not familiar with the code, I was just copying from another special page. (SpecialListusers.php in core) Also, apparently my working copy of SpecialListusers.php wasn't up to date. See also * r91461 introduced the method from my patch in SpecialListusers.php * r97658 removed the method from SpecialListusers.php cc'ing aaron and ialex (from those revs)
still broken on 1.18wmf1, r100002.
+reviewed This is still a problem, however the patch at this point isn't confirmed to fix this, and since the pagers in use here are ContextSources, is it correct to be overriding them? r97658 should probably be MFT'd to 1.18wmf1, let me talk to someone about this.
The patch is right. See r91862 for another special page which extends the UsersPager. ContextSources is not relevant here.
(In reply to comment #6) > The patch is right. See r91862 for another special page which extends the > UsersPager. ContextSources is not relevant here. r97658 says otherwise.
*** This bug has been marked as a duplicate of bug 31638 ***
But r97658 and ContextSource is 1.19. To fix this problem in 1.18 you have to override the getTitle method. Some part of r100516 was reverted after the merge with r108070
