Last modified: 2011-09-24 06:35:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33093, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31093 - Remove feature requested with bug #25295
Remove feature requested with bug #25295
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Unprioritized critical (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/wiki/Wikipedi...
:
Depends on:
Blocks: 29068
  Show dependency treegraph
 
Reported: 2011-09-22 12:31 UTC by Matthias Becker
Modified: 2011-09-24 06:35 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Becker 2011-09-22 12:31:25 UTC
After feature request 25295 was resolved any reviewer can see who in that moment is reviewing the article. Worse it does not need to click on "review" ("sichten in the German language interface) but appearantly any viewing of a diff link results in this.

I consider this new feature as critical since it can be misused for profiling other users or to make conclusions wether an article is on a user's watch list.

** The feature should be removed BEFORE the great update which lies only a few days ahead. **

See:

http://de.wikipedia.org/wiki/Datei:Sichten2.png

Greetings, Matthias
Comment 1 Erik Moeller 2011-09-22 17:13:04 UTC
I agree that while the user is told about this behavior, we can't assume that any diff view by a user with reviewer permission is the beginning of the review process, and disclose their behavior to others. If that's the current behavior, we shouldn't deploy it.

I can see that sharing this information as part of the process could be useful, but I would suggest an AJAX opt-in link on the diff view:

"Show other users that I, Eloquence, am reviewing this page now." 

That would actually keep the UI at the current level of complexity since the message could be replaced with the yellow indicator message once the link has been clicked.
Comment 2 Aaron Schulz 2011-09-22 17:59:48 UTC
(In reply to comment #0)
> After feature request 25295 was resolved any reviewer can see who in that
> moment is reviewing the article. Worse it does not need to click on "review"
> ("sichten in the German language interface) but appearantly any viewing of a
> diff link results in this.
> 
> I consider this new feature as critical since it can be misused for profiling
> other users or to make conclusions wether an article is on a user's watch list.
> 
> ** The feature should be removed BEFORE the great update which lies only a few
> days ahead. **
> 
> See:
> 
> http://de.wikipedia.org/wiki/Datei:Sichten2.png
> 
> Greetings, Matthias

Even on 1.17 you don't have to click the "review" diff links (e.g. at Special:PendingChanges). The main difference now is that:
(a) The user is told that they are advertised as reviewing the page
(b) Other users are notified that "user X is already reviewing" when they also view the diff.
Comment 3 Erik Moeller 2011-09-22 18:33:00 UTC
I think people understand that. They are objecting that their username is disclosed without their permission when they may be looking for the diff for other reasons, or may only want to apply an initial gut-feel judgment to the page, but not necessarily review it.
Comment 4 Aaron Schulz 2011-09-22 19:36:08 UTC
(In reply to comment #3)
> I think people understand that. They are objecting that their username is
> disclosed without their permission when they may be looking for the diff for
> other reasons, or may only want to apply an initial gut-feel judgment to the
> page, but not necessarily review it.

Right. I'm trying to clarify the difference in behavior. I already have a patch to disable setting the notice except from the (review) link on the special pages.
Comment 5 Aaron Schulz 2011-09-23 03:39:55 UTC
Users must now click a JS link to have them treated as reviewing a page/diff since r97886.
Comment 6 Aaron Schulz 2011-09-24 06:35:56 UTC
(In reply to comment #5)
> Users must now click a JS link to have them treated as reviewing a page/diff
> since r97886.

A few more tweaks made. Fixed on trunk.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links