Last modified: 2011-11-22 02:43:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33026, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31026 - Shortcut CTRTL+M is not always the correct shortcut
Shortcut CTRTL+M is not always the correct shortcut
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Narayam (Other open bugs)
unspecified
All Mac OS X 10.4
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ta.wikibooks.org
:
Depends on:
Blocks: 32578
  Show dependency treegraph
 
Reported: 2011-09-20 04:44 UTC by Srikanth Logic
Modified: 2011-11-22 02:43 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Srikanth Logic 2011-09-20 04:44:59 UTC
Toggling IME On/Off on a Mac fails with keyboard shortcut Control M since it minimizes the window in Mac
Comment 1 Junaid 2011-09-20 10:40:54 UTC
We can set shortcut we like, but it is very difficult to find a universally applicable one. Chances are there you selected shortcut might be already allocated by some browser.

Did you have any other shortcut that work on all browsers?
Comment 2 Srikanth Logic 2011-09-20 10:50:05 UTC
I am no Mac person, some one from UX team may have some idea?
Comment 3 Brion Vibber 2011-09-20 16:17:01 UTC
Tested Mac OS X 10.7.1, Firefox 6.0.2 -- control+M on ta.wikibooks.org toggles the Narayam state successfully.

Tested Mac OS X 10.7.1, Safari 5.1 -- control+M on ta.wikibooks.org toggles the Narayam state successfully.

Tested Mac OS X 10.7.1, Chrome 14.0.835.163 -- control+M on ta.wikibooks.org toggles the Narayam state successfully.


Note that *Command*+M minimizes windows in all three browsers.
Comment 4 Junaid 2011-09-20 19:03:52 UTC
(In reply to comment #3)
> Tested Mac OS X 10.7.1, Firefox 6.0.2 -- control+M on ta.wikibooks.org toggles
> the Narayam state successfully.
> 
> Tested Mac OS X 10.7.1, Safari 5.1 -- control+M on ta.wikibooks.org toggles the
> Narayam state successfully.
> 
> Tested Mac OS X 10.7.1, Chrome 14.0.835.163 -- control+M on ta.wikibooks.org
> toggles the Narayam state successfully.
> 
> 
> Note that *Command*+M minimizes windows in all three browsers.

Thanks.
Comment 5 Srikanth Logic 2011-09-24 04:37:15 UTC
http://tawp.in/r/2na0 Original reporter verified and says its working.
Comment 6 Siebrand Mazeland 2011-10-24 09:23:44 UTC
Reopening this bug, as just tested with Santhosh. Very different behaviours in OSX 10.7.2 in different browsers. The help text "CTRL+M" in the collapsable menu for toggling key mapping needs to be dynamic, and possibly on Firefox 7 there is also a duplicate assignment (conflictiong with CRTL+M for page move).

Preconditions:
* logged into MediaWiki with Narayam installed
* using a locale that has Narayam enabled by default (for example ta/Tamil)
* editing page the logged in user is allowed to move

Steps to reproduce:
1. press CTRL+M in edit mode

Observed behaviours:
* OSX 10.7.2/Firefox 7.0.1: pressing CTRL+M, Narayam will enable/disable, and immediately after, the page move dialog is loaded.
* OSX 10.7.2/Opera 11.51: pressing CRTL+M does nothing. Narayam toggle it CRTL+CMD+M. (page move is CRTL+ESC+M)
* OSX 10.7.2/Safari 5.1.1: pressing CTRL+M enables/disables Narayam. (page move is CTRL+ALT+M.) This is expected behaviour.
* OSX 10.7.2/Chrome 14.0.835.202: pressing CTRL+M enables/disables Narayam. (page move is CTRL+OPTION+M.) This is expected behaviour.

Expected behaviour:
* show the proper shortcut for enable/disable in the Input methods menu
* no duplicate assignment of keyboard shortcuts.
Comment 7 Santhosh Thottingal 2011-11-11 08:54:01 UTC
(In reply to comment #6)
> * OSX 10.7.2/Firefox 7.0.1: pressing CTRL+M, Narayam will enable/disable, and
> immediately after, the page move dialog is loaded.

For FF and OSX, we changed the shortcut to CTRL+G since CTRL+M is access key defined for page move.

> * OSX 10.7.2/Opera 11.51: pressing CRTL+M does nothing. Narayam toggle it
> CRTL+CMD+M. (page move is CRTL+ESC+M)

Changed the shortcut key to CTRL+CMD+M.

In all cases, the shortcut key displayed in Menu is dynamic now. The browser, os sniffing is based on the code in mediawiki.util.js

See r101790

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links