Last modified: 2014-09-04 19:31:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32795, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30795 - "Show edit toolbar" preference is confusing
"Show edit toolbar" preference is confusing
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks: edit-toolbar
  Show dependency treegraph
 
Reported: 2011-09-07 08:02 UTC by Amir E. Aharoni
Modified: 2014-09-04 19:31 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2011-09-07 08:02:10 UTC
There are two preferences when WikiEditor is installed:
1. Show edit toolbar (requires JavaScript)
2. Enable enhanced editing toolbar

The first option is not related to WikiEditor and it is only relevant to the classic toolbar. However, regular editors don't know that the new one is called "WikiEditor" or that it is enhanced. This preference has practically no effect if "Enable enhanced editing toolbar" is checked. A user may want to disable the toolbar, so he will uncheck "Show edit toolbar", but the WikiEditor will stay. That is very confusing.

I would envision something different:

* A checkbox saying "Show edit toolbar (requires JavaScript)". Should be checked by default.
** If WikiEditor is installed, then it will have radio buttons or a dropdown for selecting the kind of toolbar the user wants: classic or modern.

There are other possibilities, such as:
* showing the classic toolbar with Monobook and the new one with Vector.
* retiring the classic toolbar entirely.

Implementing this should be fairly easy, but i suppose that a decision from usability people is needed.

See also Bug 28555.
Comment 1 Helder 2012-02-22 21:10:56 UTC
See also bug 19786.
Comment 2 Helder 2014-04-08 14:51:51 UTC
I confirm that disabling "Show edit toolbar (requires JavaScript)" on
https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing
doesn't remove the toolbar if "Enable enhanced editing toolbar" is enabled. This also happens after the fix for another bug:
https://en.wikipedia.org/w/index.php?diff=603293838&oldid=603166167


I like the idea of having something like

[x] Show edit toolbar:
    (x) Classic
    ( ) Modern
    ( ) Modern with wizards for inserting links, tables as well as the search and replace function
Comment 3 Derk-Jan Hartman 2014-04-08 15:11:31 UTC
"Show edit toolbar" indeed only determines if the edit toolbar old style is included in the html. BTW, we should at the very least move that out of the HTML, so we no longer have to complicate the EditPage on the HTML level.
Comment 4 Helder 2014-04-08 15:52:39 UTC
(In reply to Derk-Jan Hartman from comment #3)
> BTW, we should at the very least move that out of the
> HTML, so we no longer have to complicate the EditPage on the HTML level.

Bug 28856?
Comment 5 George Orwell III 2014-09-02 00:30:02 UTC
(In reply to Helder from comment #2)
> >>SNIP<<
> 
> I like the idea of having something like
> 
> [x] Show edit toolbar:
>     (x) Classic
>     ( ) Modern
>     ( ) Modern with wizards for inserting links, tables as well as the
> search and replace function

Agreed. Making the User preferences for editor something like that makes far more sense - not only for improved "overall" clarity's sake - but could go a long way towards nailing down many other specific issues if it was implemented as the 'first step' in a series a steps that follow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links