Last modified: 2011-09-05 00:58:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32679, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30679 - some installer fields should always be LTR
some installer fields should always be LTR
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: rtl
  Show dependency treegraph
 
Reported: 2011-09-01 10:58 UTC by Amir E. Aharoni
Modified: 2011-09-05 00:58 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
added 'dir'=>'ltr' to some fields (2.93 KB, patch)
2011-09-01 10:58 UTC, Amir E. Aharoni
Details

Description Amir E. Aharoni 2011-09-01 10:58:25 UTC
Created attachment 9002 [details]
added 'dir'=>'ltr' to some fields

Some fields in the installer should always be dir="ltr" by default, because they are most likely Latin:

* config-upload-deleted 
* config-db-name
* config-db-prefix
* config-upload-deleted
* config-logo

In a rare case that some of these fields would be written in an RTL alphabet (an Arabic directory name, for instance), the user will be able to change the direction using Ctrl-Shift(-X).

Patch attached. It's my first PHP patch, so please be gentle :)
Comment 1 Robin Pepermans (SPQRobin) 2011-09-05 00:58:58 UTC
Patch applied in r96265.

It's sometimes hard to decide which fields should be LTR by default, imho..

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links